-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clicking on a link creates 2 requests #234
Comments
I can't reproduce... Can you provide a screen shot of where you're seeing the multiple requests "on the server"? Thanks. |
So this "bug" just cost me like 3 hours of dev time on a project because it was messing with my requests. The phantom first link was executing the action and then the 2nd real request would fail (rightfully) because the first "phantom" request already did the action the link that was "emailed" to me was supposed to do. The trick to the bug and why some may not be able to reproduce it, it seems is a default browser configuration issue. If you use EDGE as your default browser, then it's likely that you cannot reproduce this bug. My default browser is Chrome. When I click a link that was "emailed" to my papercut receptacle, I see two requests almost simulaniously on my server with two different user agents: The first (phantom) request I get: The 2nd request which I see open in my chrome: It seems like somehow papercut is trying to open the request in Edge, but my system knows chrome is my default browser so then it passes the "Job" to open the link to chrome, but never stops the Edge api from making the web request. It never actually creates an Edge window though, so you would never know this request was happening unless its messing with the secondary request being fulfilled by chrome by performing the action first breaking the action attempt for the chrome request. I was only able to finally figure this out by putting a request logger directly in my app entry point... At least I'm aware of this so I wont waste more time on this but this is a real gnarly bug. |
Describe the bug
Clicking on a html anchor link in the "Message" view of a message sends 2 requests to the server.
To Reproduce
Steps to reproduce the behavior:
<a href="{{link}}">{{link}}</a>
Expected behavior
I expect there to only be 1 request when clicking a link.
Desktop (please complete the following information):
Additional context
Maybe the issue is that the request is already sent when the NavigationStarting event is fired, so cancelling this event only has effects on the UI.
Papercut-SMTP/src/Papercut.UI/ViewModels/MessageDetailHtmlViewModel.cs
Line 193 in a1727a6
As a side note, this does not happen if opening the link by pressing ctrl and clicking the link on the "Raw" or "Body" views in PaperCut.
The text was updated successfully, but these errors were encountered: