Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zonmaker pre-compile steps #68

Merged
merged 3 commits into from Jun 26, 2021
Merged

Add zonmaker pre-compile steps #68

merged 3 commits into from Jun 26, 2021

Conversation

braem
Copy link
Member

@braem braem commented Jun 26, 2021

Closes #54

Creates the .zon file and copies it over to game, using the newly added special cmd so that trying to copy a non-existent .zon file doesnt fail the compile.

I do also have some code changes that allows this to be nicer, so that the zonmaker executable can be run with $zonmaker_exe and the zones folder can be found with $zondir.. though it required a lot of MOMENTUM ifdefs so I elected to go this route. Can always go the other route, would be nice to have zonmaker run on normal compiles too.

These always fail because we dont have a srctools.vdf in our mapsrc, making it load the default which points to portal2. To point to momentum by default instead I believe we will have to make our own version of the postcompiler.
Creates zones before vbsp and copies them over to game.
@Gocnak Gocnak merged commit 4f707de into master Jun 26, 2021
@Gocnak Gocnak deleted the feat/zonmaker branch June 26, 2021 05:15
@TeamSpen210
Copy link

Im regards to the postcompiler, it looks for the srctools.vdf config file in each parent directory from the passed in BSP, so you could place one in mapsrc or any parent folder. I'd suggest you actually do so, and say configure the auto-pack to exclude all the existing default folders, set the game folder, and whatever options seem reasonable. The default game folder is Portal 2 only because that's what I normally mod, I should make it blank and cause an error until it's set probably.

@braem
Copy link
Member Author

braem commented Jun 26, 2021

Im regards to the postcompiler, it looks for the srctools.vdf config file in each parent directory from the passed in BSP, so you could place one in mapsrc or any parent folder. I'd suggest you actually do so, and say configure the auto-pack to exclude all the existing default folders, set the game folder, and whatever options seem reasonable. The default game folder is Portal 2 only because that's what I normally mod, I should make it blank and cause an error until it's set probably.

Yeah i will add it for those that want to use it.

Though the issue i was getting at is that a large majority of our mappers are not expecting to have that file in their own mapping folders, as they have never used the postcompiler. It would be nice to have the default point to the respective game so ppl arent expected to do this. I just disabled it by default until we can think of a better solution.

TeamSpen210 added a commit to TeamSpen210/srctools that referenced this pull request Jun 27, 2021
Also allow it to be specified by -game like other compiler tools.
This fixes an issue in StrataSource/FGD#68.
@TeamSpen210
Copy link

Added a -game/--game argument working like the other compiler tools, so it can be specified there.

TeamSpen210 added a commit to TeamSpen210/HammerAddons that referenced this pull request May 21, 2022
Also allow it to be specified by -game like other compiler tools.
This fixes an issue in StrataSource#68.


Transferred from TeamSpen210/srctools @ e1e202855d6299c799abd9da7406abd43ed8e053
TeamSpen210 added a commit to TeamSpen210/HammerAddons that referenced this pull request May 24, 2022
Also allow it to be specified by -game like other compiler tools.
This fixes an issue in StrataSource#68.

Transferred from TeamSpen210/srctools @ e1e202855d6299c799abd9da7406abd43ed8e053
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Momentum's CmdSeqDefault.wc file to have Zonmaker called before VBSP
3 participants