Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log spamming on client 1.09d #63

Open
Marcelo20XX opened this issue Jul 18, 2022 · 1 comment
Open

Log spamming on client 1.09d #63

Marcelo20XX opened this issue Jul 18, 2022 · 1 comment

Comments

@Marcelo20XX
Copy link

Marcelo20XX commented Jul 18, 2022

I had an issue with the last PlugY version 14.03. When opening the stash I receive the following message on my log 20.000 times:

16:34:29.313 ----- JONM NOTE: Would have crashed, see code at ITEMSDataGetPage. From FILE: C:\Src\Diablo2\Source\D2Common\ITEMS\Items.cpp LINE: 1163

It doesn't matter if the stash is empty or with items, tested with the previous official version 11.02 and the error didn't occur there, thanks for any fix...

@PeteBurns6
Copy link

PeteBurns6 commented Dec 20, 2022

It's caused by stash tab auto rename function. You can turn it off in .ini file with AutoRenameStashPage=0.

It's not working anyway, not for 1.09d at least. Items are not getting through D2GetRealItem before D2ItemGetPage, D2GetRealItem returns -1 for every item and actual logic is never executed. If you do the wrapping game will crash since SgptDataTables are seem not to be mapped for 1.09d and below. It seem to crash for misc items too, not sure why though.

Also there are other places where D2GetRealItem is not used for D2ItemGetPage (like in changeToSelectedStash_10. maybe in those assembly functions too?).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants