Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

does not work for Angular 16 #52

Open
jasperlan666666 opened this issue Jul 29, 2023 · 0 comments
Open

does not work for Angular 16 #52

jasperlan666666 opened this issue Jul 29, 2023 · 0 comments

Comments

@jasperlan666666
Copy link

Describe the bug
Same code works well with Angular 15/14/13 until Angular 16 upgrade (16.1.6).

in app.module.ts
@NgModule({
declarations: [AppComponent],
imports: [BrowserModule,
HttpClientModule,
FormsModule,
BrowserAnimationsModule,
TranslateModule.forRoot({
loader: {
provide: TranslateLoader,
useFactory: (httpLoaderFactory),
deps: [HttpClient]
}
}),
NgxAgoraSdkNgModule.forRoot({
AppID: environment.AgoraAPIKey,
Video: { codec: 'h264', mode: 'rtc', role: 'host' }
}),

But got the follow error from Angular 16

main.ts:21 Error: Unexpected value 'NgxAgoraSdkNgModule' imported by the module 'AppModule'. Please add an @NgModule annotation.
at verifySemanticsOfNgModuleDef (core.mjs:24416:19)
at core.mjs:24427:9
at Array.forEach ()
at verifySemanticsOfNgModuleDef (core.mjs:24425:60)
at AppModule.get (core.mjs:24378:30)
at getInjectorDef (core.mjs:447:13)
at walkProviderTree (core.mjs:8887:18)
at core.mjs:8847:13
at core.mjs:5160:76
at Array.forEach ()

To Reproduce
upgrade to use Angular 16

Expected behavior
no error from using the module

Screenshots
no screenshots

Desktop (please complete the following information):

  • OS: ubuntu 20
  • Browser: Chrome
  • Version Version 115.0.5790.98 (Official Build) (64-bit)

Smartphone (please complete the following information):

  • no test with phone device yet, desktop sanity test already failed.

Additional context
Is there a plan to resolve this issue to support Angular 16?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant