New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Question about threshold of 50 pixels #3
Comments
Thank you for your question, In our implementation, there is constraint applied on the distance between each two FG points or BG points. But there is no distance constraint between FG points and BG points. This is a little bit different from what we mentioned in our paper. In class I hope this can answer your question. |
Thanks for your quick reply. Ah I am pretty sure that there is no distance constraint between FG points and BG points, but I am unsure about the use of self.r_extend. I found that this value is only used to draw the circles on trimap, but there is no constraint applied on random points sampling. To my understanding, the process is just randomly choosing points on FG/BG area, and draw a circle with radius 50 pixels. Plz correct me if my understanding is wrong. |
Please note that our points are sampled one by one. We first get That's why we use I hope this can answer your question. |
Ah I see. This is a fabulous approach! Thanks for answering my question :-) |
Hi,
Awesome work for introducing different forms of trimaps into training! After reading through the code implementation, there is one point I'm not sure about.
In 3.1.2 'Simulating User Scribbles', it says 'To avoid the points being too close to each other, we set a threshold of 50 pixels between each two points'. After going through code in dataloader/Test_dataset/data_generator.py, class Genclickmap, seems there is no strict constraint applied on the distances between randomly selected fg points and bg points.
I am not sure if I have missed some stuff, hope someone could help me. Thanks in advance.
The text was updated successfully, but these errors were encountered: