remove broad exception from classes

Charcoal-SE · Oct 7, 2018 · 3a0ffc3 · 3a0ffc3
1 parent b69ecb0
commit 3a0ffc3
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 8 deletions.
diff --git a/apigetpost.py b/apigetpost.py
@@ -38,12 +38,8 @@ def as_dict(self):
             'up_vote_count': self.up_vote_count,
             'down_vote_count': self.down_vote_count,
             'edited': (self.creation_date != self.last_edit_date),
+            'IsAnswer': getattr(self, 'IsAnswer', False),
         }
-        # noinspection PyBroadException
-        try:
-            dictdata['IsAnswer'] = getattr(self, 'IsAnswer')
-        except AttributeError:
-            dictdata['IsAnswer'] = False  # Assume it's not an answer
 
         return dictdata
 

diff --git a/classes/_Post.py b/classes/_Post.py
@@ -183,7 +183,7 @@ def answers(self):
         # noinspection PyBroadException
         try:
             return self._answers
-        except:
+        except AttributeError:
             return None
 
     @property
@@ -226,7 +226,7 @@ def post_site(self):
     def post_url(self):
         try:
             return str(self._post_url)
-        except:
+        except (AttributeError, ValueError):
             return "NoLink"
 
     @property

diff --git a/tox_classes.ini b/tox_classes.ini
@@ -1,3 +1,3 @@
 [flake8]
-ignore = E501,F403,E402,F405,N804,F401,N801,E722
+ignore = E501,F403,E402,F405,N804,F401,N801
 exclude = ChatExchange/*,.idea/*,.git/*