Skip to content

Commit

Permalink
Code owners
Browse files Browse the repository at this point in the history
  • Loading branch information
ArtOfCode- committed Oct 24, 2019
1 parent 4912704 commit 4badae0
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions CODEOWNERS
Validating CODEOWNERS rules …
@@ -0,0 +1,5 @@
# Blacklist/watchlist files are owned by true-code-admin.
*.txt @Charcoal-SE/smokedetectors

flovis.py @ArtOfCode-
socketscience.py @ArtOfCode-
File renamed without changes.

2 comments on commit 4badae0

@double-beep
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't CODEOWNERS of *.txt files be @Charcoal-SE/OAPs?

@ArtOfCode-
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@double-beep No, because those people don't have write access. Code owners are requested for review on pull requests, so it's helpful if they do have write access - I can't recall whether it's required or not, but it's definitely useful.

Please sign in to comment.