Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
4912704
commit 4badae0
Showing
2 changed files
with
5 additions
and
0 deletions.
There are no files selected for viewing
Validating CODEOWNERS rules …
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
# Blacklist/watchlist files are owned by true-code-admin. | ||
*.txt @Charcoal-SE/smokedetectors | ||
|
||
flovis.py @ArtOfCode- | ||
socketscience.py @ArtOfCode- |
File renamed without changes.
4badae0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't CODEOWNERS of
*.txt
files be@Charcoal-SE/OAPs
?4badae0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@double-beep No, because those people don't have write access. Code owners are requested for review on pull requests, so it's helpful if they do have write access - I can't recall whether it's required or not, but it's definitely useful.