Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better WebSocket error recovery in EditWatcher and DeletionWatcher #7043

Open
makyen opened this issue May 31, 2022 · 0 comments
Open

Better WebSocket error recovery in EditWatcher and DeletionWatcher #7043

makyen opened this issue May 31, 2022 · 0 comments
Labels
area: DeletionWatcher area: EditWatcher status: confirmed Confirmed as something that needs working on. type: bug Aaaah! Kill it! type: feature request Shinies.

Comments

@makyen
Copy link
Contributor

makyen commented May 31, 2022

Some of the exceptions logged here indicate we're rebooting sometimes when there's an error on the EditWatcher and/or DeletionWatcher WebSockets. We could use better recovery from WebSocket exceptions in both of these modules (which use similar code, so similar error recover seems reasonable). We already retry the main WebSocket, so it would be reasonable to have somewhat similar code in EditWatcher and DeletionWatcher.

@makyen makyen added type: bug Aaaah! Kill it! type: feature request Shinies. area: DeletionWatcher status: confirmed Confirmed as something that needs working on. area: EditWatcher labels May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: DeletionWatcher area: EditWatcher status: confirmed Confirmed as something that needs working on. type: bug Aaaah! Kill it! type: feature request Shinies.
Development

No branches or pull requests

1 participant