Skip to content

Commit

Permalink
Merge pull request #182 from Charcoal-SE/Mak-update-dependencies
Browse files Browse the repository at this point in the history
Update dependencies
  • Loading branch information
makyen committed Nov 23, 2021
2 parents e097042 + 0494806 commit 8fcf740
Show file tree
Hide file tree
Showing 15 changed files with 63,418 additions and 4,178 deletions.
4 changes: 3 additions & 1 deletion .github/workflows/build.yml
Expand Up @@ -28,4 +28,6 @@ jobs:
key: ${{ runner.os }}-${{ hashFiles('**/package-lock.json') }}

- name: build
run: './build.sh'
run: |
npm install --no-fund -g npm@^8.1.4
'./build.sh'
4 changes: 2 additions & 2 deletions build.sh
Expand Up @@ -19,7 +19,7 @@ do
done

echo "Building main project..."
npm install
npm --no-fund install
npm test
ecode=$?
if [ "$ecode" != "0" ]
Expand All @@ -33,7 +33,7 @@ for dir in ${dirs[@]} ;
do
echo "Building overridden: $dir"
cd $dir
npm install
npm --no-fund install
npm test
ecode=$?
if [ "$ecode" != "0" ]
Expand Down
6 changes: 3 additions & 3 deletions fire/fire.user.js
Expand Up @@ -1118,7 +1118,7 @@
let isReportedUrlValid = false;

if (urlOnReportLink) {
reportedUrl = reportLink[0].href.split('url=')[1]; // eslint-disable-line prefer-destructuring
reportedUrl = reportLink[0].href.split('url=')[1];
isReportedUrlValid = Boolean(reportedUrl);
}
if ((!urlOnReportLink || !isReportedUrlValid) && reportLink.nextAll('a')[0]) {
Expand Down Expand Up @@ -1365,7 +1365,7 @@
.trigger('mouseleave');

const $button = $(`.fire-popup-header a[fire-key~=${event.keyCode}]:not([disabled])`);
const button = $button[0]; // eslint-disable-line prefer-destructuring
const button = $button[0];

if (button) {
if (event.keyCode === c.keys.esc) { // [Esc] key
Expand Down Expand Up @@ -2056,7 +2056,7 @@
.map((value) => value
.split(':')
.map((secondSplit) => secondSplit.trim())));
} catch (error) {
} catch {
return {};
}
}
Expand Down

0 comments on commit 8fcf740

Please sign in to comment.