1.0.13 Fixing "Decorate existing messages" for FF

1.0.13 Fixing "Decorate existing messages" for FireFox
Charcoal-SE · May 20, 2017 · fdf6782 · fdf6782
1 parent cf4dcd3
commit fdf6782
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 5 deletions.
diff --git a/fire/README.md b/fire/README.md
@@ -59,6 +59,7 @@ To open the reported post on it's site:
 
 |1.0    ||
 | ---   |---
+|1.0.13 |Fixing "Decorate existing messages" for FireFox
 |1.0.12 |Reducing the max size of a rendered image.
 |1.0.11 |Bugfix: `decorateExistingMessages` timing.
 |1.0.10 |Bugfix: got incorrect post ID for reports where the url contains a number.

diff --git a/fire/fire.meta.js b/fire/fire.meta.js
@@ -4,7 +4,7 @@
 // @description FIRE adds a button to SmokeDetector reports that allows you to provide feedback & flag, all from chat.
 // @author      Cerbrus
 // @attribution Michiel Dommerholt (https://github.com/Cerbrus)
-// @version     1.0.12
+// @version     1.0.13
 // @updateURL   https://raw.githubusercontent.com/Charcoal-SE/Userscripts/master/fire/fire.meta.js
 // @downloadURL https://raw.githubusercontent.com/Charcoal-SE/Userscripts/master/fire/fire.user.js
 // @supportURL  https://github.com/Charcoal-SE/Userscripts/issues

diff --git a/fire/fire.user.js b/fire/fire.user.js
@@ -4,7 +4,7 @@
 // @description FIRE adds a button to SmokeDetector reports that allows you to provide feedback & flag, all from chat.
 // @author      Cerbrus
 // @attribution Michiel Dommerholt (https://github.com/Cerbrus)
-// @version     1.0.12
+// @version     1.0.13
 // @updateURL   https://raw.githubusercontent.com/Charcoal-SE/Userscripts/master/fire/fire.meta.js
 // @downloadURL https://raw.githubusercontent.com/Charcoal-SE/Userscripts/master/fire/fire.user.js
 // @supportURL  https://github.com/Charcoal-SE/Userscripts/issues
@@ -1995,7 +1995,9 @@
       // We need another timeout here, because the first modification occurs before
       // the new (old) chat messages are loaded.
       setTimeout(() => {
-        if (chat.html().length !== 0) { // Chat messages have loaded
+        if (chat.html().length === 0) { // Too soon
+          setTimeout(decorateExistingMessages, timeout, timeout);
+        } else { // Chat messages have loaded
           $(fire.SDMessageSelector).each((i, element) => decorateMessage(element));
 
           fire.log('Decorated existing messages.');

diff --git a/fire/fire.user.md b/fire/fire.user.md
@@ -709,7 +709,7 @@ keyCodesToArray - Structure the keyCodes Array.
 
 | Param | Type | Description |
 | --- | --- | --- |
-| keyCodes | <code>number</code> &#124; <code>string</code> &#124; <code>array</code> | An number, string, or array of numbers or strings containing keys or keycodes. |
+| keyCodes | <code>number</code> \| <code>string</code> \| <code>array</code> | An number, string, or array of numbers or strings containing keys or keycodes. |
 
 
 ---
@@ -726,7 +726,7 @@ createFeedbackButton - Create a feedback button for the top of the popup.
 | Param | Type | Description |
 | --- | --- | --- |
 | data | <code>object</code> | the report data. |
-| keyCodes | <code>number</code> &#124; <code>string</code> &#124; <code>array</code> | The keyCodes to use for this button. |
+| keyCodes | <code>number</code> \| <code>string</code> \| <code>array</code> | The keyCodes to use for this button. |
 | text | <code>string</code> | The text to display for this button. |
 | verdict | <code>string</code> | This button's MetaSmoke verdict |
 | tooltip | <code>string</code> | The tooltip to display for this button. |