Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

text markdown style overrides other text styles. #37

Closed
alvaromb opened this issue Mar 31, 2017 · 5 comments
Closed

text markdown style overrides other text styles. #37

alvaromb opened this issue Mar 31, 2017 · 5 comments

Comments

@alvaromb
Copy link
Contributor

alvaromb commented Mar 31, 2017

If we configure the markdown to have a text style prop like this:

{
  text: {
    color: 'black',
  },
  heading1: {
    color: 'red',
    fontSize: 20,
    fontWeight: '500',
    marginBottom: 15,
  },
}

The text color prop in the heading1 entry will be overridden. In order to customise the text color of the heading, the text entry must be removed.

PS: I know I've opened several bugs, I'll try to send PRs for them as soon as I can.

@CharlesMangwa
Copy link
Owner

Hi @alvaromb! I started working on this issue and had promising results. However, it required a little bit of refactoring but also testing all the rules. Your PRs will be very welcome 💪

@alizbazar
Copy link

The same issue seems to appear also with other tags, such as link, strong and so on. It seems to be caused by text tag always being at the root of every text, overriding any specific overlapping definitions, such as link or strong.

Essentially this prevents from changing default text color while also using different color for the links. Any ideas how to overcome this?

@alizbazar
Copy link

This would not be a problem if text wasn't at the "root" of every other textual tag. Or if there was a way to define default text styles for the top most Text tag that then could be overriden by other tags.

@ido-sa
Copy link

ido-sa commented Jun 8, 2017

hey!
any news about it? any fix?

@CharlesMangwa
Copy link
Owner

This would be handle in v2 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants