-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
why you not support CPU #34
Comments
I agree - CPU version would be very useful for debugging purposes. I'm trying to use the CornerNet code, which relies on your code (https://github.com/xingyizhou/CenterNet/tree/master/src/lib/models/networks/DCNv2). |
@azuryl @yossibiton @CharlesShang do we have cpu version of dcnv2 ? if not when can we expect the cpu version |
@abhigoku10, @yossibiton, @azuryl, I have modified DCNv2 from this repository to add the CPU functionality. I have submitted a pull request to Charles Shang, but so far there is no response from him. Have a look and try my implementation: https://github.com/palver7/DCNv2 . @CharlesShang Please have a look and comment/review on my pull request. |
your link https://github.com/palver7/DCNv2 are 404 , where can I get CPU DCNv2 . |
@palver7 thanks for sharing it , but getting 404 error can you share you the link |
Hi, @macqueen09 @abhigoku10, Charles Shang has merged my repo with his, now DCNv2 in this repo can operate using cpu or gpu. Because of this, I do not need to maintain my repo and I deleted it. That is why you get the 404 error You can re download the DCNv2 and run python3 testcpu.py to see if it runs on your cpu. |
@palver7 can you share the location of ur repo , i tried to find it but could not see in your profile thanks for doing it |
@abhigoku10 I have deleted DCNv2 from my repo. Check again this link https://github.com/CharlesShang/DCNv2 readme. it now has a line that says run python testcpu.py to check if it runs on CPU. This was from my merged repo. Also, If you check the files inside the src/cpu directory you will see that they now contain actual codes instead of the previous "not implemented on cpu" error message placeholders. You can now use Charles' DCNv2 on CPU as well as GPU. |
@palver7 @CharlesShang thanks a lot for work you guys have done !!! |
Great work! Update: |
@tabsun Hi, I am happy to hear the CPU implementation works for you. Thanks for sharing about openmp too. I was going to suggest that you try making a CPU version of the TH Cuda blas Sgemmbatched routine, since that was what Charles used (in the dcn_v2_cuda.cu file) to improve the CUDA version. I changed that to just ordinary TH float blas gemm because I cannot find the CPU version for the cuda batched gemm routine. |
it is difficult to rrealize by code?
The text was updated successfully, but these errors were encountered: