Server is unplayable when more than 1 person online

[CharlotteCross1998]

Not sure if it's a bug with the original server or my changes.

When a single player is on a server and another person joins, the server, roughly every 2-3 seconds, will cause a bit of a lag spike, rendering the game unplayable. The client sees "connection lost, reconnecting" in their corner when it happens.

The server reports no such reconnections and no issues with the performance.

[CharlotteCross1998]

Update: Server does provide commentary on the reconnects, however I don't understand why this is happening. Maybe removing the heartbeat did it?
Will re-add and modify the code to not stop the server when it fails.

Log:

[21:09:58]: [ MS] charlotte -(WLD)> 0
[21:09:58]: [PlayerSaveParser] Couldn't find save file for aaaaaaaaaaa1, or save is corrupted.
[21:09:58]: [ MS] aaaaaaaaaaa1 -(WLD)> 1
[21:09:58]: [ MS] aaaaaaaaaaa1 -> RQ CONTACT INFO
[21:09:58]: [ MS] aaaaaaaaaaa1 <- SND CONTACT INFO
[21:09:58]: [RAND] Initialized REManager for Aaaaaaaaaaa1.
[21:09:58]: [Player] Aaaaaaaaaaa1 initialising...
[21:09:58]: [LoginConfiguration] configuring player Aaaaaaaaaaa1
[21:09:58]: [LoginConfiguration] finished configuring player Aaaaaaaaaaa1
[21:09:58]: [DisconnectionQueue] Player cleared. Removed charlotte
Warning: Nashorn engine is planned to be removed from a future JDK release
[21:10:01]: [ MS] aaaaaaaaaaa1 -(WLD)> 0
[21:10:01]: [PlayerSaveParser] Parsing states
[21:10:01]: [ MS] charlotte -(WLD)> 1
[21:10:01]: [ MS] charlotte -> RQ CONTACT INFO
[21:10:01]: [ MS] charlotte <- SND CONTACT INFO
[21:10:01]: [RAND] Initialized REManager for Charlotte.
[21:10:01]: [LoginConfiguration] configuring player Charlotte
[21:10:01]: [LoginConfiguration] finished configuring player Charlotte
[21:10:02]: [DisconnectionQueue] Player cleared. Removed aaaaaaaaaaa1
Warning: Nashorn engine is planned to be removed from a future JDK release
[21:10:02]: [ MS] charlotte -(WLD)> 0
[21:10:02]: [PlayerSaveParser] Parsing states
[21:10:02]: [ MS] aaaaaaaaaaa1 -(WLD)> 1
[21:10:02]: [ MS] aaaaaaaaaaa1 -> RQ CONTACT INFO
[21:10:02]: [ MS] aaaaaaaaaaa1 <- SND CONTACT INFO
[21:10:02]: [RAND] Initialized REManager for Aaaaaaaaaaa1.
[21:10:02]: [LoginConfiguration] configuring player Aaaaaaaaaaa1
[21:10:02]: [LoginConfiguration] finished configuring player Aaaaaaaaaaa1
[21:10:04]: [DisconnectionQueue] Player cleared. Removed charlotte
Warning: Nashorn engine is planned to be removed from a future JDK release
[21:10:05]: [ MS] aaaaaaaaaaa1 -(WLD)> 0
[21:10:05]: [PlayerSaveParser] Parsing states
[21:10:05]: [ MS] charlotte -(WLD)> 1
[21:10:05]: [ MS] charlotte -> RQ CONTACT INFO
[21:10:05]: [ MS] charlotte <- SND CONTACT INFO
[21:10:05]: [RAND] Initialized REManager for Charlotte.
[21:10:05]: [LoginConfiguration] configuring player Charlotte
[21:10:05]: [LoginConfiguration] finished configuring player Charlotte
[21:10:05]: [DisconnectionQueue] Player cleared. Removed aaaaaaaaaaa1

[CharlotteCross1998]

Update: Server does provide commentary on the reconnects, however I don't understand why this is happening. Maybe removing the heartbeat did it? Will re-add and modify the code to not stop the server when it fails.

Log:

[21:09:58]: [ MS] charlotte -(WLD)> 0 [21:09:58]: [PlayerSaveParser] Couldn't find save file for aaaaaaaaaaa1, or save is corrupted. [21:09:58]: [ MS] aaaaaaaaaaa1 -(WLD)> 1 [21:09:58]: [ MS] aaaaaaaaaaa1 -> RQ CONTACT INFO [21:09:58]: [ MS] aaaaaaaaaaa1 <- SND CONTACT INFO [21:09:58]: [RAND] Initialized REManager for Aaaaaaaaaaa1. [21:09:58]: [Player] Aaaaaaaaaaa1 initialising... [21:09:58]: [LoginConfiguration] configuring player Aaaaaaaaaaa1 [21:09:58]: [LoginConfiguration] finished configuring player Aaaaaaaaaaa1 [21:09:58]: [DisconnectionQueue] Player cleared. Removed charlotte Warning: Nashorn engine is planned to be removed from a future JDK release [21:10:01]: [ MS] aaaaaaaaaaa1 -(WLD)> 0 [21:10:01]: [PlayerSaveParser] Parsing states [21:10:01]: [ MS] charlotte -(WLD)> 1 [21:10:01]: [ MS] charlotte -> RQ CONTACT INFO [21:10:01]: [ MS] charlotte <- SND CONTACT INFO [21:10:01]: [RAND] Initialized REManager for Charlotte. [21:10:01]: [LoginConfiguration] configuring player Charlotte [21:10:01]: [LoginConfiguration] finished configuring player Charlotte [21:10:02]: [DisconnectionQueue] Player cleared. Removed aaaaaaaaaaa1 Warning: Nashorn engine is planned to be removed from a future JDK release [21:10:02]: [ MS] charlotte -(WLD)> 0 [21:10:02]: [PlayerSaveParser] Parsing states [21:10:02]: [ MS] aaaaaaaaaaa1 -(WLD)> 1 [21:10:02]: [ MS] aaaaaaaaaaa1 -> RQ CONTACT INFO [21:10:02]: [ MS] aaaaaaaaaaa1 <- SND CONTACT INFO [21:10:02]: [RAND] Initialized REManager for Aaaaaaaaaaa1. [21:10:02]: [LoginConfiguration] configuring player Aaaaaaaaaaa1 [21:10:02]: [LoginConfiguration] finished configuring player Aaaaaaaaaaa1 [21:10:04]: [DisconnectionQueue] Player cleared. Removed charlotte Warning: Nashorn engine is planned to be removed from a future JDK release [21:10:05]: [ MS] aaaaaaaaaaa1 -(WLD)> 0 [21:10:05]: [PlayerSaveParser] Parsing states [21:10:05]: [ MS] charlotte -(WLD)> 1 [21:10:05]: [ MS] charlotte -> RQ CONTACT INFO [21:10:05]: [ MS] charlotte <- SND CONTACT INFO [21:10:05]: [RAND] Initialized REManager for Charlotte. [21:10:05]: [LoginConfiguration] configuring player Charlotte [21:10:05]: [LoginConfiguration] finished configuring player Charlotte [21:10:05]: [DisconnectionQueue] Player cleared. Removed aaaaaaaaaaa1

Re-implementing the heartbeat code did not fix it. Really unsure as to what's going on.