Skip to content
This repository has been archived by the owner on Apr 8, 2023. It is now read-only.

Items that require hasRandomProperties are not supported. #28

Closed
Chase-san opened this issue Oct 6, 2016 · 4 comments
Closed

Items that require hasRandomProperties are not supported. #28

Chase-san opened this issue Oct 6, 2016 · 4 comments
Labels
Bug Something that is related to something already implemented but does not work as desired.

Comments

@Chase-san
Copy link
Collaborator

Chase-san commented Oct 6, 2016

After using minerva to look at the Corny T-Shirt they are not as simple as I would hope. I am removing them from the list of items for the moment because they require support for hasRandomProperties. This basically saves all the values for a given item, which means we would require a complete copy of the data for an item to add it properly.

Without this we will get the most generic version of a given item. That means writing the "variant" property to the save for the item means nothing without that flag as well. But if we have that flag we may need all of the items data. For now I think we might want to consider a way to add custom fields to any given item without them being a property in case we have a lot of them.

This will likely involve subtags of the sort <Item ...><ItemField ID="hasRandomProperties" type="bool" value="true" /><ItemField ID="varient" type="int" value="1" /> </Item>

I think that hard light variants also use this property.

@algoRhythm99
Copy link
Owner

Ick, I was afraid something like that might be necessary, but was hoping based on the item code the variant flag was enough.

@Chase-san
Copy link
Collaborator Author

Afraid not. Also TiTsEd might erase these flags when items are edited period. Meaning it may have been mutilating item data all along.

@Chase-san
Copy link
Collaborator Author

Chase-san commented Oct 6, 2016

Actually it might be for those. But also requiring the hasRandomProperties flag. I have not personally tested it yet. Maybe we just need those two. But there are also hard light items and other things that may need different variables. So I will see about looking deeper into the item handling this weekend.

@Chase-san Chase-san added the Bug Something that is related to something already implemented but does not work as desired. label Oct 6, 2016
@Chase-san
Copy link
Collaborator Author

Chase-san commented Nov 12, 2016

It is starting to look better in my item branch, but still needs a bit of work. Additionally I made it so we can add or remove item categories via the xml.

Soon as it is done you will be able to select any item variant we have defined in the xml.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Something that is related to something already implemented but does not work as desired.
Projects
None yet
Development

No branches or pull requests

2 participants