-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This breaks functionality that relies on shutdown functions #19
Comments
Alright, there's a fix in place that requires a config option to be set that disables the call to I think it makes sense to set that option to prevent Query Monitor from disappearing. What do you think @BronsonQuick ? |
@johnbillion Awesome. I was just checking my inbox and saw that fix come through. Yeah that makes sense to me! |
@johnbillion Sorry for the delay on this. I've updated the submodule and the config so it's working again with Query Monitor. |
Unfortunately this is an issue currently. I install this plugin by adding it to the extensions list in the config.yaml for Chassis. When I load any WP screen with an admin bar, the Query Monitor menu is empty. |
Can confirm what @svandragt reported. This still seems to be broken. I've tried deleting and reinstalling all extensions and Query Monitor is still broken unless I disable the Chassis XHGUI extension. |
Yeah I'm gonna have to see if I can figure out some kinda logic so that both can work together. I'll have a bit of a play and see if I can come up with something. |
Turns out I needed to add a sha upstream to made sure this was fixed: Chassis/xhgui@daaae44...b263243#diff-b5d0ee8c97c7abd7e3fa29b9a27d1780 |
@BronsonQuick how should I test this? I tried |
@joemcgill You'll want to delete the |
Thanks, B. I tried doing this and it didn't work, but deleting both the |
Ahh right. Sounds like you needed to do a |
This is an interesting bug: perftools/xhgui-collector#19
The most visible problem this causes is that Query Monitor doesn't work when Chassis-XHGui is in use, because it uses the
shutdown
action in WordPress, which is itself attached to a shutdown function which doesn't fire due to the above bug.Opening this here for visibility and as a reminder that the fix will need to be pulled downstream.
The text was updated successfully, but these errors were encountered: