Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build portability images for VTK 9.x #51

Closed
2 tasks done
kwabenantim opened this issue Aug 9, 2023 · 7 comments · Fixed by #52
Closed
2 tasks done

Build portability images for VTK 9.x #51

kwabenantim opened this issue Aug 9, 2023 · 7 comments · Fixed by #52
Assignees
Labels
enhancement New feature or request

Comments

@kwabenantim
Copy link
Member

kwabenantim commented Aug 9, 2023

Description
We would like to run regular Chaste portability tests with VTK 9.0.x and 9.1.x.

Potential solutions:

  • Rebuild two existing portability images and replace the VTK versions with 9.0.x and 9.1.x. This is feasible as 7.1.x and 8.2.x are repeated in the current image set.
  • Create new portability images and tests for the new VTK versions.

Related Issues

To Do

  • Build portability image with VTK 9.0.x
  • Build portability image with VTK 9.1.x
@kwabenantim kwabenantim added the enhancement New feature or request label Aug 9, 2023
@kwabenantim kwabenantim self-assigned this Aug 9, 2023
@kwabenantim
Copy link
Member Author

Planned Changes to Portability Images
Before

. 01 02 03 04 05
VTK 6.3.0 7.1.1 7.1.1 8.2.0 8.2.0

After

. 01 02 03 04 05
VTK 6.3.0 7.1.1 9.0.3 8.2.0 9.1.0

@kwabenantim kwabenantim linked a pull request Aug 10, 2023 that will close this issue
@kwabenantim
Copy link
Member Author

VTK 9.0.3 build fails:

#10 981.5 In file included from /home/runner/modules/src/vtk/VTK-9.0.3/Common/Core/vtkGenericDataArray.h:72,
#10 981.5                  from /home/runner/modules/src/vtk/VTK-9.0.3/Common/Core/vtkGenericDataArray.cxx:25:
#10 981.5 /home/runner/modules/src/vtk/VTK-9.0.3/Common/Core/vtkGenericDataArrayLookupHelper.h: In function 'bool detail::isnan(T)':
#10 981.5 /home/runner/modules/src/vtk/VTK-9.0.3/Common/Core/vtkGenericDataArrayLookupHelper.h:52:26: error: 'numeric_limits' is not a member of 'std'
#10 981.5    52 |   return has_NaN<T, std::numeric_limits<T>::has_quiet_NaN>::isnan(x);
#10 981.5       |                          ^~~~~~~~~~~~~~
#10 981.5 /home/runner/modules/src/vtk/VTK-9.0.3/Common/Core/vtkGenericDataArrayLookupHelper.h:52:26: error: 'numeric_limits' is not a member of 'std'
#10 981.5 /home/runner/modules/src/vtk/VTK-9.0.3/Common/Core/vtkGenericDataArrayLookupHelper.h:52:42: error: template argument 2 is invalid
#10 981.5    52 |   return has_NaN<T, std::numeric_limits<T>::has_quiet_NaN>::isnan(x);
#10 981.5       |                                          ^
#10 981.7 In file included from /home/runner/modules/src/vtk/VTK-9.0.3/Common/Core/vtkGenericDataArray.cxx:27:
#10 981.7 /home/runner/modules/src/vtk/VTK-9.0.3/Common/Core/vtkDataArrayPrivate.txx: In function 'bool vtkDataArrayPrivate::detail::isinf(T)':
#10 981.7 /home/runner/modules/src/vtk/VTK-9.0.3/Common/Core/vtkDataArrayPrivate.txx:97:31: error: 'numeric_limits' is not a member of 'std'
#10 981.7    97 |   return has_infinity<T, std::numeric_limits<T>::has_infinity>::isinf(x);
#10 981.7       |                               ^~~~~~~~~~~~~~
#10 981.7 /home/runner/modules/src/vtk/VTK-9.0.3/Common/Core/vtkDataArrayPrivate.txx:97:31: error: 'numeric_limits' is not a member of 'std'
#10 981.7 /home/runner/modules/src/vtk/VTK-9.0.3/Common/Core/vtkDataArrayPrivate.txx:97:47: error: template argument 2 is invalid
#10 981.7    97 |   return has_infinity<T, std::numeric_limits<T>::has_infinity>::isinf(x);
#10 981.7       |  

@fcooper8472
Copy link
Member

Looks as though it's missing the <limits> header....

@kwabenantim
Copy link
Member Author

Looks as though it's missing the <limits> header....

Thanks @fcooper8472. I'll make a patch for it.

@kwabenantim
Copy link
Member Author

Possibly some useful patches here too: https://sources.debian.org/patches/vtk9/

@kwabenantim
Copy link
Member Author

The chaste/runner:jammy.portability-05 docker image now has VTK 9.1.0.

@kwabenantim
Copy link
Member Author

The chaste/runner:jammy.portability-03 docker image now has VTK 9.0.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants