Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OK to add a .eslintrc.js file? #1120

Closed
suntong opened this issue Mar 7, 2018 · 2 comments
Closed

OK to add a .eslintrc.js file? #1120

suntong opened this issue Mar 7, 2018 · 2 comments

Comments

@suntong
Copy link
Contributor

suntong commented Mar 7, 2018

I found that the wechaty doesn't have a .eslintrc.js file. Would it be OK for me to add one, since nobody is using it?

The content would be like
https://gist.github.com/suntong/3a2a1c8b10609a9d5080f289355ff09b

If so, I'll put into PR for #1100.

cheers

@suntong suntong changed the title OK to add a .eslintrc.js file OK to add a .eslintrc.js file? Mar 7, 2018
@huan
Copy link
Member

huan commented Mar 7, 2018

Thanks for your suggestion.

However, I think it's not necessary to add a .eslintrc.js because all Wechaty is written in TypeScript. We should use tslint with tslint.json instead.

And of course, if you are using Wechaty as a dependency for your project, you can add .tslintrc.js to your project root directory as well. ;)

@huan huan closed this as completed Mar 7, 2018
@suntong
Copy link
Contributor Author

suntong commented Mar 7, 2018

sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants