Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the peerDependencies of rx-queue: rxjs@6 from rxjs@5 #1205

Closed
linyimin0812 opened this issue May 14, 2018 · 9 comments
Closed

Update the peerDependencies of rx-queue: rxjs@6 from rxjs@5 #1205

linyimin0812 opened this issue May 14, 2018 · 9 comments
Labels

Comments

@linyimin0812
Copy link
Contributor

(node:5731) UnhandledPromiseRejectionWarning: TypeError: rxjs.interval is not a function
at ThrottleSubscriber.durationSelector (/home/linyimin/practice/wechaty/test/node_modules/_rx-queue@0.3.14@rx-queue/bundles/rx-queue.umd.js:181:99)
at ThrottleSubscriber.tryDurationSelector (/home/linyimin/practice/wechaty/test/node_modules/_rxjs@5.5.10@rxjs/operators/throttle.js:107:25)
at ThrottleSubscriber._next (/home/linyimin/practice/wechaty/test/node_modules/_rxjs@5.5.10@rxjs/operators/throttle.js:92:33)
at ThrottleSubscriber.Subscriber.next (/home/linyimin/practice/wechaty/test/node_modules/_rxjs@5.5.10@rxjs/Subscriber.js:93:18)
at Subject.next (/home/linyimin/practice/wechaty/test/node_modules/_rxjs@5.5.10@rxjs/Subject.js:55:25)
at ThrottleQueue.next (/home/linyimin/practice/wechaty/test/node_modules/_rx-queue@0.3.14@rx-queue/bundles/rx-queue.umd.js:185:26)
at PuppetWeb.on.data (/home/linyimin/practice/wechaty/test/node_modules/_wechaty@0.14.1@wechaty/dist/src/puppet-web/puppet-web.js:74:60)
at emitOne (events.js:121:20)
at PuppetWeb.emit (events.js:211:7)
at PuppetWeb.emit (/home/linyimin/practice/wechaty/test/node_modules/_wechaty@0.14.1@wechaty/dist/src/puppet.js:34:22)
at Watchdog.dog.on.food (/home/linyimin/practice/wechaty/test/node_modules/_wechaty@0.14.1@wechaty/dist/src/puppet-web/puppet-web.js:102:20)
at emitTwo (events.js:126:13)
at Watchdog.emit (events.js:214:7)
at Watchdog.feed (/home/linyimin/practice/wechaty/test/node_modules/_watchdog@0.3.4@watchdog/bundles/watchdog.umd.js:188:18)
at PuppetWeb.puppet.on.food (/home/linyimin/practice/wechaty/test/node_modules/_wechaty@0.14.1@wechaty/dist/src/puppet-web/puppet-web.js:98:43)
at emitOne (events.js:116:13)
at PuppetWeb.emit (events.js:211:7)
at PuppetWeb.emit (/home/linyimin/practice/wechaty/test/node_modules/_wechaty@0.14.1@wechaty/dist/src/puppet.js:34:22)
at PuppetWeb. (/home/linyimin/practice/wechaty/test/node_modules/_wechaty@0.14.1@wechaty/dist/src/puppet-web/event.js:53:14)
at Generator.next ()
at fulfilled (/home/linyimin/practice/wechaty/test/node_modules/_wechaty@0.14.1@wechaty/dist/src/puppet-web/event.js:4:58)
at
at process._tickDomainCallback (internal/process/next_tick.js:228:7)
(node:5731) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:5731) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

@huan
Copy link
Member

huan commented May 14, 2018

This is because the RxJS v5.5.10 has some BREAKING CHANGES.

Try to install the specific rxjs@5.5.0 by run: npm install rxjs@5.5.0 and try again.

UPDATE: we need rxjs@6 instead of rxjs@5 because of the rx-queue update.

@linyimin0812
Copy link
Contributor Author

OK,I will have a try. Thanks!

@linyimin0812
Copy link
Contributor Author

I have installed the specific rxjs@5.5.0 by run: npm install rxjs@5.5.0 and try again.But it dose not work.

@huan
Copy link
Member

huan commented May 14, 2018

What Wechaty version are you using?

Please remember to submit the version first before you ask questions.

@timqian
Copy link
Member

timqian commented May 15, 2018

Met same issue on
node v10.0.0/v8.9.1
npm v5.6.0
wechaty v0.14.1

remove rxjs and reinstall 5.5.0 did not help either.

huan added a commit that referenced this issue May 15, 2018
@huan huan changed the title There is something wrong info when start Update the peerDependencies of rx-queue: rxjs@6 from rxjs@5 May 15, 2018
@huan
Copy link
Member

huan commented May 15, 2018

@timqian Thanks for your report with the details version information, and sorry I had made a mistake in the previous reply:

We need upgrade rxjs to v6 to follow the requirement of rx-queue

Wechaty v0.14.2 or above should fix this issue, please test and feel free to let me know if you are still having problems.

@huan huan added the bug label May 15, 2018
@huan
Copy link
Member

huan commented May 18, 2018

@lym152898 @timqian Could you please to confirm that whether the v0.14.2 or above version of Wechaty resolve this issue?

@linyimin0812
Copy link
Contributor Author

Yes, the issue is resolved when use rxjs@6 in wechaty@0.14.4

@huan
Copy link
Member

huan commented May 19, 2018

Thank you for the confirmation.

@huan huan closed this as completed May 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants