Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

添加用 id 寻找Room RoomQueryFilter #1785

Closed
xinbenlv opened this issue May 23, 2019 · 3 comments
Closed

添加用 id 寻找Room RoomQueryFilter #1785

xinbenlv opened this issue May 23, 2019 · 3 comments

Comments

@xinbenlv
Copy link
Contributor

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

NO

Describe the solution you'd like
A clear and concise description of what you want to happen.

添加用 id 寻找Room RoomQueryFilter

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

[enhancement]

@xinbenlv
Copy link
Contributor Author

这个可以用 Room.load(id:string)这个接口,请ignore

@huan
Copy link
Member

huan commented Jun 30, 2019

I decide to implement this feature because:

  1. Room.load() is not a public API
  2. Room.load() can not guarantee the id is valid
  3. Room.load() cannot throw the exception when the id is invalid

So add an id to the QueryFilter will be a better way to resolve the above problems.

@huan huan reopened this Jun 30, 2019
huan added a commit to wechaty/puppet that referenced this issue Jun 30, 2019
huan added a commit to wechaty/puppet-wechat that referenced this issue Jun 30, 2019
@huan
Copy link
Member

huan commented Jun 30, 2019

Using id as a QueryFilter key had been supported by:

  1. wechaty-puppet-puppeteer@0.17.22 or later version
  2. wechaty-puppet-padpro@unknown: after this PR had been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants