Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add check isMentionMe method #1532

Merged
merged 6 commits into from
Aug 10, 2018
Merged

add check isMentionMe method #1532

merged 6 commits into from
Aug 10, 2018

Conversation

bitwater
Copy link
Contributor

@bitwater bitwater commented Aug 7, 2018

add check isMentionedMe method

[√] Feature

Checklist

Description

Does this PR introduce a breaking change?

[√] No

@bitwater
Copy link
Contributor Author

bitwater commented Aug 7, 2018

Oh, all failed

@bitwater bitwater closed this Aug 7, 2018
@lijiarui
Copy link
Member

lijiarui commented Aug 8, 2018

@bitwater Why did you close this pr? I think this function may necessary thought the function name is not that appropriate.

@bitwater
Copy link
Contributor Author

bitwater commented Aug 9, 2018

@lijiarui How about isMentionMe?zixia suggest me send a Pull Request to add it to the library

@bitwater bitwater reopened this Aug 9, 2018
@bitwater
Copy link
Contributor Author

bitwater commented Aug 9, 2018

Sorry, need more test

@bitwater bitwater changed the title add check isMentionedMe method add check isMentionMe method Aug 10, 2018
@bitwater
Copy link
Contributor Author

Why is appveyor that error ?

Error: listen EADDRINUSE 127.0.0.1:10513
    at Server.setupListenHandle [as _listen2] (net.js:1335:14)
    at listenInCluster (net.js:1383:12)
    at doListen (net.js:1509:7)
    at process._tickCallback (internal/process/next_tick.js:63:19)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR!

@huan
Copy link
Member

huan commented Aug 10, 2018

This new method of Message class will be very useful, thank you very much for the contribution!

@huan huan merged commit d568569 into wechaty:master Aug 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants