add the methods' doc link #1583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add most methods' doc link and change RoomInvitation `topic` to `roomTopic`
|
Add the corresponding doc link for most methods. |
huan
reviewed
Sep 3, 2018
|
However, it seems that this pull request is conflict with the code base Could you please fix the conflict before we can be able to better it? |
|
Seems that i have no write access to merge the PR. |
|
Yes, you have no write access. To solve the conflict, you need to sync your branch with the upstream master, and commit your latest code after you had success merged all the changes |
|
Oh, i have sync the changes to latest version. |
|
Awesome. Thank you very much for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.