Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix document presentation bugs #1713

Merged
merged 7 commits into from Mar 5, 2019
Merged

fix document presentation bugs #1713

merged 7 commits into from Mar 5, 2019

Conversation

TbhT
Copy link
Contributor

@TbhT TbhT commented Mar 1, 2019

No description provided.

@TbhT TbhT mentioned this pull request Mar 1, 2019
@huan
Copy link
Member

huan commented Mar 2, 2019

That's great enhancement for the documentation!

Please ask other contributors to review your changes and get at least 1 approvement for this PR before I could be able to merge it.

Thank you very much!

@huan huan requested a review from a team March 2, 2019 00:12
Copy link
Member

@lijiarui lijiarui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change link to https://docs.chatie.io/ since we have update all new docs, thanks!

UPDATED by @huan:
@lijiarui the document in the README should point to chatie.io/wechaty because it is generated directly from the source code.

README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@xinbenlv xinbenlv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@huan huan requested a review from a team March 2, 2019 06:12
@lijiarui
Copy link
Member

lijiarui commented Mar 2, 2019

@huan well, I think we should unify the docs to developers, or they may feel confused but it ups to you.

And also, people don't sync the latest jsdoc when they commit. I have pr jsdoc for your commit several times.

So I suggest using docs.chatie.io only.

@huan
Copy link
Member

huan commented Mar 2, 2019

  1. From this repo, the doc should be linked to the https://chatie.io/wechaty, which webroot is the /docs in this repo.
  2. From other places, the doc should be linked to the https://docs.chatie.io

@lijiarui That's it.

@TbhT Please fix the conflicting and get at least one approvement for this PR, then I'll be able to merge this PR. Thank you very much.

@huan
Copy link
Member

huan commented Mar 5, 2019

I resolved the conflicted part and will merge it because of @xinbenlv LGTH.

@xinbenlv it would be better if you could click the approve button in the PR review mode so that your approvement will be clear for the community. Thanks for the approvement anyway.

@huan huan merged commit e2c763b into wechaty:master Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants