Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add example code #1757

Merged
merged 2 commits into from Apr 25, 2019
Merged

add example code #1757

merged 2 commits into from Apr 25, 2019

Conversation

linyimin0812
Copy link
Contributor

refer #1756

@huan huan requested a review from windmemory April 24, 2019 17:22
windmemory
windmemory requested changes Apr 25, 2019
View reviewed changes
Copy link
Member

@windmemory windmemory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The example code in message.say() needs to be fixed.

src/user/message.ts
@@ -469,6 +469,18 @@ export class Message extends Accessory implements Sayable {
* }
*
* })
*
* // 4. send Link
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This piece of code should be in the bracket below.

windmemory
windmemory approved these changes Apr 25, 2019
View reviewed changes
Copy link
Member

@windmemory windmemory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes looks good to me.

@huan
Copy link
Member

huan commented Apr 25, 2019

@windmemory Thanks for the review!
@linyimin-bupt Good job!

@huan huan merged commit 3764730 into wechaty:master Apr 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@windmemory windmemory windmemory approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@linyimin0812 @huan @windmemory