New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load all memberList #275

Merged
merged 8 commits into from Mar 1, 2017

Conversation

Projects
None yet
3 participants
@lijiarui
Member

lijiarui commented Feb 22, 2017

@zixia

No, I don't think this can fix anything.

@lijiarui

This comment has been minimized.

Show comment
Hide comment
@lijiarui

lijiarui Feb 22, 2017

Member

Then, what's your suggestion?

Member

lijiarui commented Feb 22, 2017

Then, what's your suggestion?

@zixia

This comment has been minimized.

Show comment
Hide comment
@zixia

zixia Feb 22, 2017

Member

My suggestion is: keep thinking hard, instead of keep asking.

Member

zixia commented Feb 22, 2017

My suggestion is: keep thinking hard, instead of keep asking.

@lijiarui lijiarui closed this Feb 22, 2017

@zixia

This comment has been minimized.

Show comment
Hide comment
@zixia

zixia Feb 22, 2017

Member

The best practice of making Pull Request is to keep improving it instead of closing it because close it will lose all the review information.

Member

zixia commented Feb 22, 2017

The best practice of making Pull Request is to keep improving it instead of closing it because close it will lose all the review information.

@lijiarui lijiarui reopened this Feb 23, 2017

Show outdated Hide outdated src/room.ts Outdated
Show outdated Hide outdated src/room.ts Outdated
Show outdated Hide outdated src/room.ts Outdated
Show outdated Hide outdated src/room.ts Outdated
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Feb 28, 2017

Coverage Status

Changes Unknown when pulling 2f11cc1 on lijiarui:273 into ** on wechaty:master**.

coveralls commented Feb 28, 2017

Coverage Status

Changes Unknown when pulling 2f11cc1 on lijiarui:273 into ** on wechaty:master**.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Feb 28, 2017

Coverage Status

Changes Unknown when pulling c7e7cf3 on lijiarui:273 into ** on wechaty:master**.

coveralls commented Feb 28, 2017

Coverage Status

Changes Unknown when pulling c7e7cf3 on lijiarui:273 into ** on wechaty:master**.

@zixia

Please rethink the design.

Show outdated Hide outdated src/room.ts Outdated
Show outdated Hide outdated src/room.ts Outdated
Show outdated Hide outdated src/room.ts Outdated
Show outdated Hide outdated src/room.ts Outdated
@lijiarui

This comment has been minimized.

Show comment
Hide comment
@lijiarui

lijiarui Feb 28, 2017

Member

You are right, it's really a bad design

Member

lijiarui commented Feb 28, 2017

You are right, it's really a bad design

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Feb 28, 2017

Coverage Status

Changes Unknown when pulling 56be013 on lijiarui:273 into ** on wechaty:master**.

coveralls commented Feb 28, 2017

Coverage Status

Changes Unknown when pulling 56be013 on lijiarui:273 into ** on wechaty:master**.

@zixia

I don't know what are you thinking. It seems you had lost your mind.

Show outdated Hide outdated src/room.ts Outdated
Show outdated Hide outdated src/room.ts Outdated
Show outdated Hide outdated src/room.ts Outdated
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Feb 28, 2017

Coverage Status

Changes Unknown when pulling 81c2400 on lijiarui:273 into ** on wechaty:master**.

coveralls commented Feb 28, 2017

Coverage Status

Changes Unknown when pulling 81c2400 on lijiarui:273 into ** on wechaty:master**.

@zixia

After this, I believe the code change can be reduced to no more than 5 lines.

Show outdated Hide outdated src/room.ts Outdated
Show outdated Hide outdated src/room.ts Outdated
Show outdated Hide outdated src/room.ts Outdated
@zixia

zixia approved these changes Mar 1, 2017

Better now.

@zixia zixia merged commit 52cde27 into Chatie:master Mar 1, 2017

4 of 5 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
ci/circleci Your tests passed on CircleCI!
Details
codacy/pr Good work! A positive pull request.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
security/snyk No new vulnerabilities
Details

@lijiarui lijiarui deleted the lijiarui:273 branch Mar 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment