Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ws to the latest version 🚀 #426

Merged
merged 1 commit into from
Apr 20, 2017
Merged

Update ws to the latest version 🚀 #426

merged 1 commit into from
Apr 20, 2017

Conversation

greenkeeper[bot]
Copy link
Contributor

@greenkeeper greenkeeper bot commented Apr 20, 2017

Version 2.3.1 of ws just got published.

Dependency ws
Current Version 2.3.0
Type dependency

The version 2.3.1 is not covered by your current version range.

Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.

I recommend you look into these changes and try to get onto the latest version of ws.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.


Release Notes 2.3.1

Bug fixes

  • Fixed an issue that prevented WebSocket.prototype.close() from working
    properly if called from a listener of the headers event.
Commits

The new version differs by 2 commits .

  • 732aaf0 [dist] 2.3.1
  • 3633d6c [fix] Make WebSocket#close() work when called from a headers listener

See the full diff.

Not sure how things should work exactly?

There is a collection of frequently asked questions and of course you may always ask my humans.


Your Greenkeeper Bot 🌴

@coveralls
Copy link

coveralls commented Apr 20, 2017

Coverage Status

Coverage remained the same at 54.903% when pulling 4214c65 on greenkeeper/ws-2.3.1 into 8dc3831 on master.

@huan huan merged commit b2a0aab into master Apr 20, 2017
@greenkeeper greenkeeper bot deleted the greenkeeper/ws-2.3.1 branch April 20, 2017 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants