Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

may be not need .vscode folder, need .editorconfig #489

Closed
huhuanming opened this issue May 5, 2017 · 7 comments
Closed

may be not need .vscode folder, need .editorconfig #489

huhuanming opened this issue May 5, 2017 · 7 comments
Labels

Comments

@huhuanming
Copy link

huhuanming commented May 5, 2017

.vscode/settings.json

{
    "editor.tabSize": 2, 
    "typescript.tsdk": "./node_modules/typescript/lib"
}

the editor.tabSize can controlled by .editorconfig.
but now, the user setting and workspace setting polluted by it.

It seemed like a good idea that remove .vscode and add .editorconfig file

@huan
Copy link
Member

huan commented May 5, 2017

Yes, I agree with you that tabSize is not necessary at here, and should be removed.(I just did it)

However, vscode/settings.json have some feature that not supported by .editorconfig.

I.e: files.exclude to hide directory/files in the ide interface.

@huan huan added the bug label May 5, 2017
@huhuanming
Copy link
Author

but the project does not use these features, such as files.exclude.
Modern editors support .editorconfig.

Wouldn't it make more sense?

@huhuanming
Copy link
Author

huhuanming commented May 5, 2017

Dust to dusts, dirt to dirts, ash to ashes

editor.tabaSize to .editorconfig, files.exclude to .tsconfig

all not to .vscode/settings.json

@huan
Copy link
Member

huan commented May 5, 2017

No, I'm afraid that I can not agree with you about this.

Because file.exclude@.vscode/settings.json is totally different with exclude@tsconfig.json. ;-)

See: How do I hide certain files from the sidebar in Visual Studio Code?

And in additional: I want to use the version of TypeScript packaged with the project, instead of the VSCode bundled version. So that's what "typescript.tsdk": "./node_modules/typescript/lib" mean.

@huhuanming
Copy link
Author

sorry, i make a mistake on it.

@huan
Copy link
Member

huan commented May 5, 2017

@huhuanming No problem buddy, and thank you for the warm-hearted suggestion.

Please feel free to let me know if you have any other good ideas. :)

@huhuanming
Copy link
Author

sweet, thx.

@huan huan closed this as completed May 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants