add: Message.forward() forward message #727

binsee · 2017-08-13T00:44:48Z

You can directly forward files and multimedia, but limit the file size to 25Mb or less, otherwise it will fail because the server policy.

Issues: #726

You can directly forward files and multimedia, but limit the file size to 25Mb or less, otherwise it will fail because the server policy.

binsee · 2017-08-13T00:46:05Z

screenshot:

binsee · 2017-08-13T00:58:24Z

demo code:

const QrcodeTerminal  = require('qrcode-terminal')
const finis           = require('finis')

/**
 * Change `import { ... } from '../'`
 * to     `import { ... } from 'wechaty'`
 * when you are runing with Docker or NPM instead of Git Source.
 */
import {
  config,
  Wechaty,
  log,
  MediaMessage,
  MsgType,
}               from './'

//const roomArr = { }

const welcome = `
| __        __        _           _
| \\ \\      / /__  ___| |__   __ _| |_ _   _
|  \\ \\ /\\ / / _ \\/ __| '_ \\ / _\` | __| | | |
|   \\ V  V /  __/ (__| | | | (_| | |_| |_| |
|    \\_/\\_/ \\___|\\___|_| |_|\\__,_|\\__|\\__, |
|                                     |___/

=============== Powered by Wechaty ===============
`

console.log(welcome)
const bot = Wechaty.instance({ profile: config.DEFAULT_PROFILE })

const forwards = <string[]>[]

bot
.on('logout'	, user => log.info('Bot', `${user.name()} logouted`))
.on('login'	  , user => {
  log.info('Bot', `${user.name()} logined`)
  bot.say('Wechaty login')
})
.on('error'   , e => {
  log.info('Bot', 'error: %s', e)
  bot.say('Wechaty error: ' + e.message)
})
.on('scan', (url, code) => {
  if (!/201|200/.test(String(code))) {
    const loginUrl = url.replace(/\/qrcode\//, '/l/')
    QrcodeTerminal.generate(loginUrl)
  }
  console.log(`${url}\n[${code}] Scan QR Code in above url to login: `)
})
.on('message', async m => {
  try {
    const room = m.room()
    const forwardId = room ? m.obj.room as string : m.obj.from as string
    const name = room ? room.topic() as string : m.from().name() as string
    let doForward = false
    console.log((room ? '[' + room.topic() + ']' : '')
                + '<' + m.from().name() + '>'
                + ':' + m.toStringDigest(),
    )
    if (!m.self()) {
      if (/^(ding|ping|bing|code)$/i.test(m.toString())) {
        doForward = true
        m.say('dong')
        log.info('Bot', 'REPLY: dong')
        await m.say(new MediaMessage(__dirname + '/../image/BotQrcode.png'))
        await m.say('Scan now, because other Wechaty developers want to talk with you too!\n\n(secret code: wechaty)')
        log.info('Bot', 'REPLY: Image')
      } else if (/^(forward|f)$/i.test(m.toString())) {
        if (forwards.indexOf(forwardId) < 0) {
          forwards.push(forwardId)
          await m.say(`你为${room ? '群[' + name + ']' : '自己'}订阅了信息转发，稍后接收到的信息将转发给${room ? '群' : '你'}`)
        } else {
          await m.say(`${room ? '群[' + name + ']' : '自己'} 已经订阅了信息转发`)
        }
      } else if (/^(unforward|unf)$/i.test(m.toString())) {
        if (forwards.indexOf(forwardId) >= 0) {
          forwards.splice(forwards.indexOf(forwardId), 1)
          await m.say(`你为${room ? '群[' + name + ']' : '自己'}取消了信息转发，稍后接收到的信息将转发给${room ? '群' : '你'}`)
        } else {
          await m.say(`${room ? '群[' + name + ']' : '自己'} 已经取消了信息转发`)
        }
      } else if (/^(list)$/i.test(m.toString())) {
        await m.say(`当前订阅列表数量为${forwards.length}\n列表如下：\n${forwards.join(',\n')}`)
      } else if (/^(帮助|help|h|使用)$/i.test(m.toString())) {
          await m.say(`你可以在任意聊天界面发送指令订阅/取消订阅信息同步\n'forward' 或 'f' 指令订阅，\n'unforward' 或 'unf' 指令取消订阅\n'list'查看订阅列表\n'help'查看帮助`)
      } else {
        doForward = true
        // 有效消息，且当前聊天未参与同步转发
        if (m.toString().length > 0 && forwards.indexOf(forwardId) < 0) {
          await m.say(`你发的消息内容为： '${m.toString()}'`)
          await m.say(`你可以在任意聊天界面发送指令订阅/取消订阅信息同步\n'forward' 或 'f' 指令订阅，\n'unforward' 或 'unf' 指令取消订阅\n'list'查看订阅列表\n'help'查看帮助`)
        }
      }

      //过滤系统信息
      if (m.type() === MsgType.SYSNOTICE || m.type() === MsgType.SYS) {
        log.info('Bot', '系统信息，不转发')
        doForward = false
      }
      // 过滤 桔小子 bot的 转发信息
      if (/(消息来自)/i.test(m.toString())) {
        doForward = false
        log.info('Bot', '检测到疑似其他Bot信息，不转发')
      }
    }
    if (doForward) {
      forwards.forEach(id => {
        if (id !== forwardId) { // 避免转发到当前会话
          m.forward(id)
        } else {
          log.info('forwards.forEach()', `id=${id},forwardId=${forwardId}`)
        }
      });
    } else {
      log.info('Bot', 'doForward=false')
    }
    } catch (e) {
      log.error('Bot', 'on(message) exception: %s', e)
    }
  })

bot.init()
.catch(e => {
  log.error('Bot', 'init() fail: %s', e)
  bot.quit()
  process.exit(-1)
})

finis((code, signal) => {
  const exitMsg = `Wechaty exit ${code} because of ${signal} `
  console.log(exitMsg)
  bot.say(exitMsg)
})

binsee · 2017-08-13T01:45:50Z

Thanks for @lijiarui !

parameter support Room/Contact/roomId/ContactId

  public forward(room: Room): Promise<any>
  public forward(contact: Contact): Promise<any>
  public forward(id: string): Promise<any>
  public forward(sendTo: string|Room|Contact): Promise<any> {}

huan

Hi @binsee, your forward implementation is awesome!

This will help the wechaty user very much when we are dealing with many attachments.

I have some questions and suggestions for your PR, please read my review, and let me know if you have any question/suggestion.

Looking forward to merge your new PR, thanks!

huan · 2017-08-13T09:09:36Z

src/message.ts

@@ -42,7 +42,9 @@ export interface MsgRawObj {
  MMActualSender:   string, // getUserContact(message.MMActualSender,message.MMPeerUserName).isContact()
  MMPeerUserName:   string, // message.MsgType == CONF.MSGTYPE_TEXT && message.MMPeerUserName == 'newsapp'
  ToUserName:       string,
+  FromUserName:     string,


MsgRawObj is the object from the WebWxApp.

Does FromUserName and Content exist in the structure?

Just want to confirm that.

When MsgType in [1,3,43,47,49],FromUserName and Content exist..
Other unconfirmed.

Then I think it's enough for us to believe that they always exist.

huan · 2017-08-13T09:11:05Z

src/message.ts

@@ -132,6 +134,16 @@ export interface MsgRawObj {
   * MsgType == CONF.MSGTYPE_VERIFYMSG
   */
  RecommendInfo?:   RecommendInfo,
+
+  /**
+   * Transpond Message


Do those attributes all exist in the WebWxApp data structure?

Need to confirm them too.

Not exist.
I will fix it.

Thanks. Let's make the MsgRawObj reflect and only reflect the WebWxApp data struct.

huan · 2017-08-13T09:13:01Z

src/message.ts

+   */
+  public forward(room: Room): Promise<any>
+  public forward(contact: Contact): Promise<any>
+  public forward(id: string): Promise<any>


Send to UserId should not be supported.

The API of Message class should be abstracted with the Room and Contact, but not the UserName or other id.

huan · 2017-08-13T09:14:30Z

src/message.ts

+  public forward(room: Room): Promise<any>
+  public forward(contact: Contact): Promise<any>
+  public forward(id: string): Promise<any>
+  public forward(sendTo: string|Room|Contact): Promise<any> {


Should return Promise<boolean>, according to the forward function in wechaty-bro.js

I will fix it.

huan · 2017-08-13T09:15:39Z

src/message.ts

+  public forward(contact: Contact): Promise<any>
+  public forward(id: string): Promise<any>
+  public forward(sendTo: string|Room|Contact): Promise<any> {
+    const m = <MsgRawObj>this.rawObj


Why <MsgRawObj> is needed here?

Does not the this.rawObj already that type?

When I remove it, the typescript check will be error.

src/message.ts(645,35): error TS2532: Object is possibly 'undefined'. src/message.ts(645,61): error TS2532: Object is possibly 'undefined'. src/message.ts(646,28): error TS2532: Object is possibly 'undefined'. src/message.ts(648,43): error TS2532: Object is possibly 'undefined'. src/message.ts(650,9): error TS2532: Object is possibly 'undefined'. src/message.ts(651,30): error TS2532: Object is possibly 'undefined'. src/message.ts(652,9): error TS2532: Object is possibly 'undefined'. src/message.ts(653,25): error TS2532: Object is possibly 'undefined'. src/message.ts(654,9): error TS2532: Object is possibly 'undefined'. src/message.ts(655,50): error TS2532: Object is possibly 'undefined'. src/message.ts(658,16): error TS2345: Argument of type 'MsgRawObj | undefined' is not assignable to parameter of type 'MsgRawObj'. Type 'undefined' is not assignable to type 'MsgRawObj'

That is because this.rawObj might be undefined.

So you need to check undefined instead of force it to be MsgRawObj.

Add the follow code at the begining of the function, then you will be able to use this.rawObj because that will make sure it is not undefined.

if (!this.rawObj) { throw new Error('no rawObj!') }

huan · 2017-08-13T09:24:10Z

src/puppet-web/bridge.ts

@@ -422,6 +423,20 @@ export class Bridge {
              })
  }

+  public forward(baseData: MsgRawObj, patchData: MsgRawObj): Promise<boolean> {


As I asked before: could we just use forward(rawObj: MsgRawObj) at here?

After thinking, I can only do this design.

Ok, I understood after reading the code you provided. Thanks.

huan · 2017-08-13T09:24:54Z

src/puppet-web/bridge.ts

+    if (!patchData.MMActualContent && !patchData.MMSendContent) {
+      throw new Error('cannot say nothing')
+    }
+    return this.proxyWechaty('forward', baseData, patchData)


Also need to merge two args to one at here.

huan · 2017-08-13T09:25:39Z

src/puppet-web/puppet-web.ts

@@ -490,6 +491,26 @@ export class PuppetWeb extends Puppet {
    return ret
  }

+  public async forward(baseData: MsgRawObj, patchData: MsgRawObj): Promise<boolean> {


forwrd(rawObj: MsgRawObj)

huan · 2017-08-13T09:26:00Z

src/puppet-web/wechaty-bro.js

@@ -505,6 +505,32 @@
    return true
  }

+  function forward(baseData, patchData) {


One parameter please

huan · 2017-08-13T09:26:30Z

src/puppet.ts

@@ -54,6 +55,7 @@ export abstract class Puppet extends EventEmitter implements Sayable {
  public abstract self(): Contact

  public abstract send(message: Message | MediaMessage): Promise<boolean>
+  public abstract forward(baseData: MsgRawObj, patchData: MsgRawObj): Promise<boolean>


One parameter.

binsee · 2017-08-13T12:21:59Z

About baseData and patchData: This design is needed

transpondDialogController in WxApp:

  angular.module("Controllers").controller("transpondDialogController", ["$rootScope", "$scope", "$timeout", "$state", "$log", "$document", "chatFactory", "contactFactory", "appFactory", "chatroomFactory", "confFactory", "mmpop", "ngDialog", "utilFactory", "stateManageService", "accountFactory",
    function(e, t, a, n, i, o, chatFactory, c, s, l, confFactory, f, u, m, g, accountFactory) {
      function h(msg, userName) {
        if (e.MsgType != confFactory.MSGTYPE_SYS) {
          var newMsg = angular.copy(msg);
          newMsg.ToUserName = userName;
          newMsg.FromUserName = accountFactory.getUserName();
          newMsg.isTranspond = !0;
          newMsg.MsgIdBeforeTranspond = msg.MsgIdBeforeTranspond || msg.MsgId;
          newMsg._h = void 0;
          newMsg._offsetTop = void 0;
          newMsg.MMSourceMsgId = msg.MsgId;
          newMsg.Scene = 2;
          newMsg = chatFactory.createMessage(newMsg); // call createMessage()

          // The following parameters need to be overridden after calling createMessage()
          newMsg.sendByLocal = !1;
          newMsg.Content = m.htmlDecode(newMsg.Content.replace(/^@\w+:<br\/>/, ""));
          newMsg.MMActualSender = accountFactory.getUserName();
          newMsg.MMSendContent && (newMsg.MMSendContent = newMsg.MMSendContent.replace(/^@\w+:\s/, ""));
          newMsg.MMDigest && (newMsg.MMDigest = newMsg.MMDigest.replace(/^@\w+:/, ""));
          newMsg.MMActualContent && (newMsg.MMActualContent = m.clearHtmlStr(newMsg.MMActualContent.replace(/^@\w+:<br\/>/, "")));

          // append and send message
          chatFactory.appendMessage(newMsg);
          chatFactory.sendMessage(newMsg)
        }
      }

chatFactory.createMessage() in WxApp:

createMessage: function(e) { // 创建消息体
  switch (e.FromUserName || (e.FromUserName = accountFactory.getUserName()),
    e.ToUserName || (e.ToUserName = this.getCurrentUserName()), //
    e.ClientMsgId = e.LocalID = e.MsgId = (utilFactory.now() + Math.random().toFixed(3)).replace(".", ""), //生成本地消息id
    e.CreateTime = Math.round(utilFactory.now() / 1e3),
    e.MMStatus = confFactory.MSG_SEND_STATUS_READY, //标记消息的状态为准备状态
    e.sendByLocal = !0, // 是否是本地信息，如果需要转发文件，必须为 false
    e.MsgType) { //判断消息类型

    case confFactory.MSGTYPE_TEXT:
      var t = [];
      e.Content = e.Content.replace(/<input.*?un="(.*?)".*?value="(.*?)".*?>/g,
          function(e, a, n) {
            return t.push(a), n
          }),
        e.MMAtContacts = t.join(","),
        e.MMSendContent = utilFactory.htmlDecode(utilFactory.clearHtmlStr(e.Content.replace(/<(?:img|IMG).*?text="(.*?)".*?>/g,
          function(e, t) {
            return t.replace(confFactory.MM_EMOTICON_WEB, "")
          }).replace(/<(?:br|BR)\/?>/g, "\n"))).replace(/<(.*?)>/g, function(e) {
          return emojiFactory.EmojiCodeMap[emojiFactory.QQFaceMap[e]] || e
        }),
        e.Content = e.Content.replace(/<(?!(img|IMG|br|BR))[^>]*>/g, "").replace(/\n/g, "<br>");
      break;

    case confFactory.MSGTYPE_APP:
      if (e.AppMsgType == confFactory.APPMSGTYPE_URL) break;
      e.AppMsgType = confFactory.APPMSGTYPE_ATTACH,
        e.Content = "<msg><appmsg appid='wxeb7ec651dd0aefa9' sdkver=''><title>" + e.FileName + "</title><des></des><action></action><type>" + confFactory.APPMSGTYPE_ATTACH + "</type><content></content><url></url><lowurl></lowurl><appattach><totallen>" + e.FileSize + "</totallen><attachid>#MediaId#</attachid><fileext>" + (e.MMFileExt || e.MMAppMsgFileExt) + "</fileext></appattach><extinfo></extinfo></appmsg></msg>"
  }
  return e
},

foraward() in wechaty-bro

  function forward(baseData, patchData) {
    var chatFactory = WechatyBro.glue.chatFactory
    var confFactory = WechatyBro.glue.confFactory

    if (!chatFactory || !confFactory) {
      log('forward() chatFactory or confFactory not exist.')
      return false
    }

    try {
      var m = chatFactory.createMessage(baseData)

      // Need to override the parametes after called createMessage()
      m = Object.assign(m, patchData)

      chatFactory.appendMessage(m)
      chatFactory.sendMessage(m)
    } catch (e) {
      log('forward() exception: ' + e.message)
      return false
    }
    return true
  }

In addition, some notes are added.

huan

Thank you for update the PR and let me know the pattern of WebWxApp of forwarding messages.

This PR will LGTM after you follow my reviews and mark all of them to be resolved.

huan · 2017-08-13T16:19:29Z

src/message.ts

+   */
+  public forward(room: Room): Promise<boolean>
+  public forward(contact: Contact): Promise<boolean>
+  public forward(id: string): Promise<boolean>


Send to UserId should not be supported.

The API of Message class should be abstracted with the Room and Contact, but not the UserName or other id.

huan · 2017-08-13T16:23:57Z

src/message.ts

+    // The following parameters need to be overridden after calling createMessage()
+
+    // If you want to forward the file, would like to skip the duplicate upload, sendByLocal must be false.
+    // But need to pay attention to file.size> 25Mb, due to the server policy restrictions, need to re-upload


Could we reuse the MediaId instead of re-upload it?

Because some projects use the MediaId directly, which means it might be valid across sessions and accounts.

See: #422 (comment)

I think the solution should be not to upload the same media file twice by caching the MediaId of the Uploaded File and reuse it in the future.

There also has a very interesting project that we could have a look: 微信表情轰炸器

It can send emoticon by MediaId directly, no need to upload anything.

The project 微信表情轰炸器 is worth having a look! :)

It only stores the MediaId, and reuse it for sending the emoticons.

By using fiddler to intercept data, testing found files larger than 25mb in webwx can not use mediaId for multiplexing, the server will return processing failure.
I think this problem needs to be shelved and later resolved. Need to refactor the upload file flow.

"BaseResponse": { "Ret": 1, "ErrMsg": "" }

huan · 2017-08-13T16:32:27Z

src/message.ts

+      newMsg.MMActualContent = UtilLib.stripHtml(m.MMActualContent.replace(/^@\w+:<br\/>/, ''))
+
+    return config.puppetInstance()
+      .forward(m, newMsg)


Ok, let's keep the patch data design because it's the pattern from WebWxApp.

huan · 2017-08-13T16:32:59Z

src/puppet-web/bridge.ts

@@ -422,6 +423,20 @@ export class Bridge {
              })
  }

+  public forward(baseData: MsgRawObj, patchData: MsgRawObj): Promise<boolean> {


Ok, I understood after reading the code you provided. Thanks.

huan

Thanks for the update.

I'll approve it after you follow my latest reviews.

Nice job!

huan · 2017-08-16T15:19:36Z

src/message.ts

+  public forward(contact: Contact): Promise<any>
+  public forward(id: string): Promise<any>
+  public forward(sendTo: string|Room|Contact): Promise<any> {
+    const m = <MsgRawObj>this.rawObj


That is because this.rawObj might be undefined.

So you need to check undefined instead of force it to be MsgRawObj.

Add the follow code at the begining of the function, then you will be able to use this.rawObj because that will make sure it is not undefined.

if (!this.rawObj) { throw new Error('no rawObj!') }

huan

Update the outdated reviews for the MsgRawObj undefined problem.

huan · 2017-08-16T15:25:49Z

src/message.ts

+  public forward(room: Room): Promise<boolean>
+  public forward(contact: Contact): Promise<boolean>
+  public forward(sendTo: Room|Contact): Promise<boolean> {
+    const m = <MsgRawObj>this.rawObj


That is because this.rawObj might be undefined.

So you need to check undefined instead of force it to be MsgRawObj.

Add the follow code at the begining of the function, then you will be able to use this.rawObj because that will make sure it is not undefined.

if (!this.rawObj) { throw new Error('no rawObj!') }

@userid

fix: When forwarding a message within a group, the content is prefixed with @userid.

huan

Thanks for your great job!

LGTM now.

I'll merge this PR after it getting total three approvements, and I'd like to tag a new version of v0.9 after we confirmed the code can work without any problem.

Looking forward to the new version, Cheers!

huan · 2017-08-16T18:20:56Z

src/message.ts

+    // The following parameters need to be overridden after calling createMessage()
+
+    // If you want to forward the file, would like to skip the duplicate upload, sendByLocal must be false.
+    // But need to pay attention to file.size> 25Mb, due to the server policy restrictions, need to re-upload


The project 微信表情轰炸器 is worth having a look! :)

It only stores the MediaId, and reuse it for sending the emoticons.

``` m.forward(Room.load(id), { user: '$USER', room: 'Room[$ROOM]', custom: 'forward from $ROOM$USER' }) // source message: 'test msg' // from room: 'testRoom' // from user: 'Bot' // forward message: `forward from Room[testRoom]Bot:\ntest msg` ```

huan

I think the forward methods should be moved from the class Message to MediaMessage.

huan · 2017-08-16T19:50:58Z

src/message.ts

+   */
+  public forward(room: Room, option?: ForwardOption): Promise<boolean>
+  public forward(contact: Contact, option?: ForwardOption): Promise<boolean>
+  public forward(sendTo: Room|Contact, option?: ForwardOption): Promise<boolean> {


I think the forward methods should be moved from the class Message to MediaMessage.

Your opinion I agree, i will move it.

I think again.
Initially I put the message in the message, hoping to achieve through a single function of multi-group live.
In the multi-group live operation, text, voice, pictures are more types of messages.
And only use forward () this method, you can easily achieve a variety of message types of forwarding.
So, will forward () be retained in Message or maybe?

Please see my comment about this at: #726 (comment)

In room msg, the content prefix sender:, need to be removed, otherwise the forwarded sender will display the source message sender, causing self () to determine the error

huan · 2017-08-17T10:00:43Z

src/message.ts

+    newMsg.sendByLocal = false
+    newMsg.MMActualSender = config.puppetInstance().userId || ''
+    if (m.MMSendContent)
+      newMsg.MMSendContent = m.MMSendContent.replace(/^@\w+:\s/, '')


Please always use { and } around the code block inside if.

huan · 2017-08-18T04:36:56Z

@binsee Could you please mark all the reviews from me as resolved?

Because I'm ok with all of them. After marked as resolved, the outdated reviews will be hidden in the "Files Change" UI.

Thanks!

huan · 2017-08-18T10:08:23Z

Thanks for the reply the "resolved" to my reviews.

But I remember that there has a [resolved] button under each review, which you could click that button to make the review as resolved state. Could you find it?

resolved wechaty#726

binsee · 2017-08-18T20:14:48Z

@zixia Sorry,I can't find it.
And I search 'resolved' in github help,still not found.

coveralls · 2017-08-18T20:54:32Z

Changes Unknown when pulling 0a76682 on binsee:add-transpond-msg into ** on Chatie:master**.

lijiarui

looks good to me, Thanks!

binsee · 2017-08-31T10:17:37Z

@hczhcz
Can I invite you to take the time to review this pr?
I hope this enhancement can be open to everyone to use, thanks!

hczhcz

This Message.forward implementation is great!

Please run jsdoc (npm run doc) so that the new API will take effect in the documentation.

binsee · 2017-09-01T08:43:15Z

@hczhcz
This development branch is at an earlier time, and the implementation of npm run doc 's index.md does not contain the contents of message.js. The latest master branch has fixed the problem, and if I execute this command, I need to create a development branch based on the latest master branch and submit it.
I think that by @zixia merge this branch, the implementation of this order is more time-saving.

Or I can submit a new development branch that invites more than three members to review.

Please tell me which way to choose? Thanks!

hczhcz

Ok. Please go ahead. It is not necessary to create another PR, just take care when merging. (Since the code has changed much when this PR is pending, there probably be a lot of things to do in the merging process...) Anyway, do not worry about that :D Thank you for your contribution!

huan · 2017-09-01T16:09:37Z

Great! Thanks all for the time of reviewing the code, appreciate it!

add: Message.forward(id) forward message

fd48f03

You can directly forward files and multimedia, but limit the file size to 25Mb or less, otherwise it will fail because the server policy.

binsee mentioned this pull request Aug 13, 2017

Add Transpond Message #726

Closed

fix(forward): parameter support Room/Contact/roomId/ContactId

de566c5

huan requested review from mukaiu, JasLin, dcsan, xinbenlv, a user, Gcaufy, imWildCat, hailiang-wang, hczhcz and TingYinHelen August 13, 2017 08:55

huan requested changes Aug 13, 2017

View reviewed changes

fix(message): fix some attributes not exist in the WebWxApp structure

83f3fce

fix(message): fix forward return Promise<boolean>

f9e42de

In addition, some notes are added.

huan requested changes Aug 13, 2017

View reviewed changes

binsee added 2 commits August 16, 2017 18:35

fix(message) remove suppot forward(id : string)

910b15b

fix(message): add a prompt for file size in forward()

58c4112

huan requested a review from lijiarui August 16, 2017 15:21

huan requested changes Aug 16, 2017

View reviewed changes

huan reviewed Aug 16, 2017

View reviewed changes

binsee added 2 commits August 17, 2017 00:16

fix(message): add the code to check if rawObj is undefined

e453822

fix(message): fix msg content error of forward group message

ce678a3

fix: When forwarding a message within a group, the content is prefixed with @userid.

huan approved these changes Aug 16, 2017

View reviewed changes

huan removed the request for review from imWildCat August 16, 2017 18:26

binsee added 3 commits August 17, 2017 02:47

fix(message): only MsgType is TEXT, add forward from info

cb3eb39

fix(bridge): fix only emoji can't forward

5c0611a

huan reviewed Aug 16, 2017

View reviewed changes

binsee added 2 commits August 17, 2017 14:32

changge(message): move forward() from class Message to MediaMessage

ea3e638

fix(message): fix the error of forward room video

5f8503d

In room msg, the content prefix sender:, need to be removed, otherwise the forwarded sender will display the source message sender, causing self () to determine the error

huan reviewed Aug 17, 2017

View reviewed changes

fix(message): add '{' and '}'

b88133c

doc(message): Supplementary forward() of jsdoc comments

0a76682

resolved wechaty#726

huan changed the title ~~add: Message.forward(id) forward message~~ add: Message.forward() forward message Aug 19, 2017

lijiarui approved these changes Aug 27, 2017

View reviewed changes

binsee mentioned this pull request Aug 31, 2017

[bug] Support for send 25Mb+ size files #766

Closed

hczhcz suggested changes Aug 31, 2017

View reviewed changes

fix(message): fix the comment for forward()

141823d

hczhcz approved these changes Sep 1, 2017

View reviewed changes

Merge branch 'master' into add-transpond-msg

e1d6d85

huan merged commit 4957489 into wechaty:master Sep 1, 2017

binsee deleted the add-transpond-msg branch September 2, 2017 04:39

huan mentioned this pull request Sep 6, 2017

Invite @binsee to write a blog about what he like. wechaty/docusaurus#42

Closed

add: Message.forward() forward message #727

add: Message.forward() forward message #727

Conversation

binsee commented Aug 13, 2017 • edited Loading

binsee commented Aug 13, 2017

binsee commented Aug 13, 2017 • edited Loading

binsee commented Aug 13, 2017

huan left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

huan Aug 13, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

binsee Aug 13, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

binsee commented Aug 13, 2017

huan left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

huan left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

huan left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

huan left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

huan left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

binsee Aug 16, 2017 • edited Loading

Choose a reason for hiding this comment

huan Aug 17, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

huan commented Aug 18, 2017

huan commented Aug 18, 2017

binsee commented Aug 18, 2017

coveralls commented Aug 18, 2017 • edited Loading

lijiarui left a comment

Choose a reason for hiding this comment

binsee commented Aug 31, 2017

binsee commented Aug 13, 2017 •

edited

Loading

binsee commented Aug 13, 2017 •

edited

Loading

huan Aug 13, 2017 •

edited

Loading

binsee Aug 13, 2017 •

edited

Loading

binsee Aug 16, 2017 •

edited

Loading

huan Aug 17, 2017 •

edited

Loading

coveralls commented Aug 18, 2017 •

edited

Loading

hczhcz left a comment •

edited

Loading

hczhcz left a comment •

edited

Loading