Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement /marker command #2360

Merged
merged 19 commits into from
Jan 30, 2021
Merged

Conversation

zneix
Copy link
Collaborator

@zneix zneix commented Jan 14, 2021

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Description

Requires Chatterino/login#10

Command was tested in webchat and I managed to replicate its behaviour in 100%.

Closes #1109

@Mm2PL
Copy link
Collaborator

Mm2PL commented Jan 15, 2021

Please add a case for anon users :-)

@zneix
Copy link
Collaborator Author

zneix commented Jan 15, 2021

Please add a case for anon users :-)

Good idea, added it in 7573d59

@zneix zneix marked this pull request as ready for review January 15, 2021 19:39
src/providers/twitch/api/README.md Outdated Show resolved Hide resolved
src/providers/twitch/api/README.md Outdated Show resolved Hide resolved
@zneix
Copy link
Collaborator Author

zneix commented Jan 17, 2021

We just tested it with @Mm2PL on livestream and triple-checked scopes of a token that we're using for creating stream marker and scope user:edit:broadcast doesn't seem to be required for marker creation. A possible Twitch bug?

@pajlada
Copy link
Member

pajlada commented Jan 30, 2021

Thank you for your contribution! ❤️

@pajlada pajlada changed the title Create /marker command Implement /marker command Jan 30, 2021
@pajlada pajlada merged commit 278a00a into Chatterino:master Jan 30, 2021
@zneix zneix deleted the feature/add-marker-command branch February 2, 2021 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add /marker command (from twitch chat)
3 participants