New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrated block, unblock and get user block list methods to Helix #2370
Migrated block, unblock and get user block list methods to Helix #2370
Conversation
…lock-list-to-helix
…lock-list-to-helix
and re-oredred some other changelog entries, so we have all migration-related entries together
The only issue remaining is that whenever you open a usercard of ignored user, you actually call |
…lock-list-to-helix
…lock-list-to-helix
…lock-list-to-helix
Also wrapped those in "deprecated commands" section along with already deprecated "/logs" command
…lock-list-to-helix
…lock-list-to-helix
this stops the user card from accidentally activating a block
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
Pull request checklist:
CHANGELOG.md
was updated, if applicableDescription
Requires Chatterino/login#11
This pull request migrates the methods related to blocking (
TwitchAccount::ignoreUser
) and unblocking (TwitchAccount::unignoreUser
) users, as well as it also makesTwitchAccount::loadIgnores
use Helix API call respectively, totally purging Kraken usage from this area.Note to pajlada: Prior to looking into this PR, plz merge #2360 first.thanksPartially completes #1928