Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrated block, unblock and get user block list methods to Helix #2370

Merged
merged 30 commits into from Feb 14, 2021

Conversation

zneix
Copy link
Collaborator

@zneix zneix commented Jan 17, 2021

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Description

Requires Chatterino/login#11

This pull request migrates the methods related to blocking (TwitchAccount::ignoreUser) and unblocking (TwitchAccount::unignoreUser) users, as well as it also makes TwitchAccount::loadIgnores use Helix API call respectively, totally purging Kraken usage from this area.

Note to pajlada: Prior to looking into this PR, plz merge #2360 first. thanks

Partially completes #1928

Decided to re-fetch whole list on (un)ignoring users rather than fuck around with some std::set's
and re-oredred some other changelog entries, so we have all migration-related entries together
@zneix zneix changed the title Migrated block list fetching to Helix Migrated block, unblock and get user block list methods to Helix Jan 28, 2021
@zneix
Copy link
Collaborator Author

zneix commented Jan 28, 2021

The only issue remaining is that whenever you open a usercard of ignored user, you actually call Helix::blockUser due to checkbox being updated, even though user is already ignored. Will have to come up with a fix for that, but other than that, if anyone wants to give their input on this PR, it's ready for review.

@zneix zneix marked this pull request as ready for review January 28, 2021 20:47
CHANGELOG.md Outdated Show resolved Hide resolved
src/widgets/dialogs/UserInfoPopup.cpp Outdated Show resolved Hide resolved
src/widgets/dialogs/UserInfoPopup.cpp Outdated Show resolved Hide resolved
src/widgets/dialogs/UserInfoPopup.cpp Outdated Show resolved Hide resolved
src/widgets/dialogs/UserInfoPopup.cpp Outdated Show resolved Hide resolved
src/widgets/dialogs/UserInfoPopup.cpp Outdated Show resolved Hide resolved
src/widgets/dialogs/UserInfoPopup.cpp Outdated Show resolved Hide resolved
@zneix zneix requested a review from pajlada February 6, 2021 21:30
Copy link
Member

@pajlada pajlada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@pajlada pajlada merged commit 7d9f4c2 into Chatterino:master Feb 14, 2021
@zneix zneix deleted the feature/migrate-block-list-to-helix branch February 14, 2021 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants