Added ability to toggle visibility of tabs #2600

zneix · 2021-04-07T16:09:16Z

Pull request checklist:

CHANGELOG.md was updated, if applicable.
Toggle tab visibility with a shortcut (Ctrl+U).
Toggle tab visibility with a Split header context menu entry.
Show dialog upon hiding tabs for the first time.

Description

This Pull Request adds an ability to toggle visibility of chat tabs - With a keyboard shortcut (Ctrl + U) and a Split header's context menu entry ("Toggle visibility of tabs").

Open questions

Currently, (in both vertical and horizontal tab layouts) special buttons are still visible. Question is whether we gonna get rid of those if tabs are hidden or not. I personally say those could stay, but I'm not 100% sure if that's what we want.

Demonstration

Related #1484
Closes #2313

…-for-vhns

This way follows the approach that was taken for the `showAddButton_` variable.

…-for-vhns

jupjohn · 2021-04-18T05:02:28Z

Implements feature of #2313

…-for-vhns

Signed-off-by: zneix <zneix@zneix.eu>

This is for consistency purposes, discussed it with @YungLPR in my chat (https://cdn.zneix.eu/EiZpfnp.png)

leon-richardt

The keybinding Ctrl+U should also be added to the "Keybindings" page in the settings.

Other than that, I like the implementation. Feels nice to use from my perspective :)

src/widgets/Notebook.cpp

src/widgets/Window.cpp

src/widgets/settingspages/GeneralPage.cpp

src/widgets/Notebook.cpp

jupjohn

Wording changes could be made.

leon-richardt

I tested it and other than this little nitpick, looks good and works just as expected 👌

src/widgets/Notebook.cpp

jupjohn

I couldn't break it, looks good to me 👍

ALazyMeme · 2021-05-29T09:48:25Z

Works fine on Windows 21H1, leaves a little space, but it appears to be windows related:

Showing tabs:

Without tabs:

If you have quite a few more tabs, it will minimize down to just a single blank line (as shown in the second screenshot).

pajlada

Small changelog entry nitpick, other than that looks good 👌

CHANGELOG.md

ALazyMeme · 2021-05-29T10:10:55Z

Found this weird bug too, only seems to occur on windows?

…bar for right-clicking in case the tabs are hidden For horizontal tab layouts, this will make the already-existing bar smaller For vertical tab layouts, this will add the small bar

pajlada · 2021-05-29T10:46:41Z

@ALazyMeme Could you test 'tab area' width/height in horizontal/vertical mode in the latest build please?

ALazyMeme · 2021-05-29T11:08:57Z

Line is still there, looks a bit weird now that there's random space on the side (since the space was not there before and the line is evidently moved upon the "creation" of the space)

Bug outlined in #2600 (comment)

Random space:

pajlada · 2021-05-29T11:41:35Z

gotta review paint event to ensure it's aligned with the 'empty space' logic

pajlada · 2021-05-30T10:20:12Z

@ALazyMeme Once the Windows build has succeeded, could you please take this for one (hopefully last) spin? Thank you!

Known 'quirks': Swapping between horizontal and vertical tab layout will result in the line around buttons (if you have buttons enabled) to not fully settle until you have pressed ok in the settings dialog.

zneix · 2021-05-30T11:05:24Z

I (sadly) tested this on Windows and this seems fine

ALazyMeme

Yes, this works perfectly.

pajlada

LGTM 👍
Would be good to have the phrase "tab area" added to the glossary

Changes from upstream we pulled: 5735428 (origin/master, origin/HEAD, master) Added ability to toggle visibility of tabs (Chatterino#2600) 01bda9c Fix tab direction not applying to popup window (Chatterino#2839) faae2c2 Match game names exactly when using /setgame (Chatterino#2825) 7e4f8be Bump ilammy/msvc-dev-cmd from 1.8.0 to 1.8.1 (Chatterino#2828) 708670b Bump actions/cache from 2.1.5 to 2.1.6 (Chatterino#2830)

Alicyl · 2021-07-01T05:03:59Z

Sorry to intrude upon this lovely little thread, but where can one access the version of Chatterino with this feature (or when can we expect if it's inaccessible to the public)? Nightly builds?

ALazyMeme · 2021-07-01T08:31:08Z

Nightly builds?

Yes.

ichigo-gyunyu · 2021-07-04T09:51:43Z

Hello, is there a way to have the tabs be hidden by default on launch and hitting Ctrl + U toggles visibility like usual. Tried to find search the settings but couldn't find any option :/

pajlada · 2021-07-04T09:54:47Z

Hello, is there a way to have the tabs be hidden by default on launch and hitting Ctrl + U toggles visibility like usual. Tried to find search the settings but couldn't find any option :/

There is not, no

zneix and others added 8 commits December 12, 2020 23:04

Initial work, very dirty solution

0a331ba

Merge remote-tracking branch 'upstream/master' into feature/hide-tabs…

56dd23b

…-for-vhns

Further work, introduced areTabsHidden variable

724318e

Merge remote-tracking branch 'upstream/master' into feature/hide-tabs…

13c8379

…-for-vhns

ref: implement tab hiding differently (#3)

2f09820

This way follows the approach that was taken for the `showAddButton_` variable.

Merge branch 'master' into feature/hide-tabs-for-vhns

e4d0603

Merge branch 'master' into feature/hide-tabs-for-vhns

b134c4b

Merge remote-tracking branch 'upstream/master' into feature/hide-tabs…

dea5566

…-for-vhns

zneix added 6 commits April 18, 2021 18:55

Merge remote-tracking branch 'upstream/master' into feature/hide-tabs…

cae6a7a

…-for-vhns

Made sure Tab Add Button is now shown if tabs are hidden

7c2989c

Signed-off-by: zneix <zneix@zneix.eu>

Added changelog entry

c29431c

Added popup upon hiding tabs for the first time

d6d9bd3

Added an entry to split header's context menu

3a9a69b

Made custom buttons show up if tabs are hidden

2d3d1a3

This is for consistency purposes, discussed it with @YungLPR in my chat (https://cdn.zneix.eu/EiZpfnp.png)

zneix marked this pull request as ready for review April 18, 2021 19:37

leon-richardt requested changes Apr 19, 2021

View reviewed changes

zneix added 7 commits April 19, 2021 10:03

Revert change to Ctrl+Shift+T shortcut

1b9da3e

Actually revert that newPage assignment

653b1f9

Added Ctrl+U to KeyboardSettingsPage.cpp

1e3a1b0

Cleaned up code, added comment about it

ae8f426

Simplify popup logic according to YungLPR's feedback

61c6142

Added window title to popup

06b2834

Removed pointless setting from general page

6a77d9a

leon-richardt approved these changes Apr 19, 2021

View reviewed changes

jupjohn reviewed Apr 20, 2021

View reviewed changes

src/widgets/Notebook.cpp Outdated Show resolved Hide resolved

jupjohn suggested changes Apr 20, 2021

View reviewed changes

Changed wording in the popup to be more user-friendly

e6cf43a

jupjohn approved these changes Apr 21, 2021

View reviewed changes

Merge branch 'master' into feature/hide-tabs-for-vhns

e88677e

zneix added 2 commits May 26, 2021 21:18

Add missing header

db5b77f

Updated instructions in info popup's

026af22

leon-richardt requested changes May 26, 2021

View reviewed changes

src/widgets/Notebook.cpp Outdated Show resolved Hide resolved

Nitpicks

c71b005

leon-richardt approved these changes May 26, 2021

View reviewed changes

jupjohn approved these changes May 27, 2021

View reviewed changes

pajlada requested changes May 29, 2021

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

zneix and others added 2 commits May 29, 2021 12:33

Updated changelog entry

7adb9af

Ensure vertical and horizontal tab layout modes all leave a tiny tab …

cc0b71f

…bar for right-clicking in case the tabs are hidden For horizontal tab layouts, this will make the already-existing bar smaller For vertical tab layouts, this will add the small bar

Clean up logic for 'minimum tab area space'

5e43dc3

ALazyMeme approved these changes May 30, 2021

View reviewed changes

pajlada approved these changes May 30, 2021

View reviewed changes

Merge branch 'master' into feature/hide-tabs-for-vhns

c2c2f8d

zneix enabled auto-merge (squash) May 30, 2021 11:22

zneix merged commit 5735428 into Chatterino:master May 30, 2021

zneix deleted the feature/hide-tabs-for-vhns branch May 30, 2021 11:40

zneix mentioned this pull request Oct 9, 2021

Add keybindings to tab context menu items #3265

Merged

1 task

pajlada mentioned this pull request Oct 16, 2021

Collapsable chat tabs. #1484

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added ability to toggle visibility of tabs #2600

Added ability to toggle visibility of tabs #2600

zneix commented Apr 7, 2021 •

edited

Loading

jupjohn commented Apr 18, 2021

leon-richardt left a comment

jupjohn left a comment

leon-richardt left a comment

jupjohn left a comment

ALazyMeme commented May 29, 2021

pajlada left a comment

ALazyMeme commented May 29, 2021

pajlada commented May 29, 2021

ALazyMeme commented May 29, 2021

pajlada commented May 29, 2021

pajlada commented May 30, 2021

zneix commented May 30, 2021

ALazyMeme left a comment

pajlada left a comment

Alicyl commented Jul 1, 2021

ALazyMeme commented Jul 1, 2021 •

edited

Loading

ichigo-gyunyu commented Jul 4, 2021

pajlada commented Jul 4, 2021

Added ability to toggle visibility of tabs #2600

Added ability to toggle visibility of tabs #2600

Conversation

zneix commented Apr 7, 2021 • edited Loading

Description

Open questions

jupjohn commented Apr 18, 2021

leon-richardt left a comment

Choose a reason for hiding this comment

jupjohn left a comment

Choose a reason for hiding this comment

leon-richardt left a comment

Choose a reason for hiding this comment

jupjohn left a comment

Choose a reason for hiding this comment

ALazyMeme commented May 29, 2021

pajlada left a comment

Choose a reason for hiding this comment

ALazyMeme commented May 29, 2021

pajlada commented May 29, 2021

ALazyMeme commented May 29, 2021

pajlada commented May 29, 2021

pajlada commented May 30, 2021

zneix commented May 30, 2021

ALazyMeme left a comment

Choose a reason for hiding this comment

pajlada left a comment

Choose a reason for hiding this comment

Alicyl commented Jul 1, 2021

ALazyMeme commented Jul 1, 2021 • edited Loading

ichigo-gyunyu commented Jul 4, 2021

pajlada commented Jul 4, 2021

zneix commented Apr 7, 2021 •

edited

Loading

ALazyMeme commented Jul 1, 2021 •

edited

Loading