Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle moderation mode and filters in split popup #3130

Merged
merged 3 commits into from Aug 6, 2021

Conversation

talneoran
Copy link
Contributor

@talneoran talneoran commented Aug 6, 2021

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Description

Respect moderation mode status and active filters when opening a split as a popup.

Fixes #3113

Copy link
Collaborator

@Felanbird Felanbird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality works as intended. 👍
image

@Mm2PL Mm2PL self-requested a review August 6, 2021 20:47
Copy link
Collaborator

@Mm2PL Mm2PL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zneix zneix merged commit 9d90de6 into Chatterino:master Aug 6, 2021
@talneoran talneoran deleted the split-popup-fixes branch August 6, 2021 22:10
zneix added a commit to SevenTV/chatterino7 that referenced this pull request Aug 8, 2021
Now we're on commit a216e11; Changes from upstream we've pulled:

- Minor: Remove TwitchEmotes.com attribution and the open/copy options when right-clicking a Twitch Emote. (Chatterino#2214, Chatterino#3136)
- Minor: Strip leading @ and trailing , from username in /user and /usercard commands. (Chatterino#3143)
- Minor: Display a system message when reloading subscription emotes to match BTTV/FFZ behavior (Chatterino#3135)
- Bugfix: Moderation mode and active filters are now preserved when opening a split as a popup. (Chatterino#3113, Chatterino#3130)
- Bugfix: Fixed a bug that caused all badge highlights to use the same color. (Chatterino#3132, Chatterino#3134)
- Dev: Renamed CMake's build option `USE_SYSTEM_QT5KEYCHAIN` to `USE_SYSTEM_QTKEYCHAIN`. (Chatterino#3103)
- Dev: Add benchmarks that can be compiled with the `BUILD_BENCHMARKS` CMake flag. Off by default. (Chatterino#3038)
- Dev: Allow building against Qt 5.11 (Chatterino#3105)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keep filters when opening a split as a popout
4 participants