Show system message when reloading subscriber emotes #3135
Conversation
There was a problem hiding this comment.
LGTM 👍
On a side note: Just wondering if wording "Twitch subscriber emotes" is correct nowadays. It used to be like that, but now we also have follower and bit emotes as well. Potential wording change would also mean changing that phrasing in KeybindingsPage.cpp and couple places in SplitHeader.cpp.
Start a separate issue/discussion for that - out of scope |
Yeah I don't think it should be a part of this one, I'm just sharing my idea here and an issue / PR could be made out of my comment later. |
Now we're on commit a216e11; Changes from upstream we've pulled: - Minor: Remove TwitchEmotes.com attribution and the open/copy options when right-clicking a Twitch Emote. (Chatterino#2214, Chatterino#3136) - Minor: Strip leading @ and trailing , from username in /user and /usercard commands. (Chatterino#3143) - Minor: Display a system message when reloading subscription emotes to match BTTV/FFZ behavior (Chatterino#3135) - Bugfix: Moderation mode and active filters are now preserved when opening a split as a popup. (Chatterino#3113, Chatterino#3130) - Bugfix: Fixed a bug that caused all badge highlights to use the same color. (Chatterino#3132, Chatterino#3134) - Dev: Renamed CMake's build option `USE_SYSTEM_QT5KEYCHAIN` to `USE_SYSTEM_QTKEYCHAIN`. (Chatterino#3103) - Dev: Add benchmarks that can be compiled with the `BUILD_BENCHMARKS` CMake flag. Off by default. (Chatterino#3038) - Dev: Allow building against Qt 5.11 (Chatterino#3105)
Pull request checklist:
CHANGELOG.mdwas updated, if applicableDescription
This PR aims to display a system message when reloading subscriber emotes. This behaviour is in line with the BTTV/FFZ emote reload behaviour.
I've passed through the channel to
loadEmoteswhich might be ugly to some people but it ensures you get a 'reloaded' messages when the reloading has started instead of when the method was called. Also kept the oldloadEmotes()overload around for the call inIRCMessagehandler.