Allow resub messages to show in /mentions tab #3148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zneix
approved these changes
Aug 8, 2021
Felanbird
approved these changes
Aug 8, 2021
|
Using the test message stuff in In the channel: In |
pajlada
approved these changes
Aug 15, 2021
zneix
added a commit
to SevenTV/chatterino7
that referenced
this pull request
Aug 15, 2021
Now we're on commit 1d664f8; Changes from upstream we've pulled: - Minor: Allow resub messages to show in `/mentions` tab (Chatterino#3148) - Minor: Added a setting to hide similar messages by any user. (Chatterino#2716) - Minor: Duplicate spaces now count towards the display message length. (Chatterino#3002) - Minor: Commands are now backed up. (Chatterino#3168) - Bugfix: Restored ability to send duplicate `/me` messages. (Chatterino#3166) - Bugfix: Notifications for moderators about other moderators deleting messages can now be disabled. (Chatterino#3121)
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist:
CHANGELOG.mdwas updated, if applicableDescription
This PR aims to fix resub messages not showing in the mentions tab when they trigger a highlight. Previously resub/sub messages were explicitly excluded from the
/mentionstab (for whatever reason). This clause has been removed.The sub message block (first clause in the highlight parser) has had the return statement removed so it can handle more highlights. I've added checks to see if the message is a sub message in all other highlight checking blocks so the colour of the sub message isn't overridden.
Fixes #1013