Fix /me not going through upon sending an identical message #3166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mm2PL
approved these changes
Aug 14, 2021
pajlada
approved these changes
Aug 15, 2021
zneix
added a commit
to SevenTV/chatterino7
that referenced
this pull request
Aug 15, 2021
Now we're on commit 1d664f8; Changes from upstream we've pulled: - Minor: Allow resub messages to show in `/mentions` tab (Chatterino#3148) - Minor: Added a setting to hide similar messages by any user. (Chatterino#2716) - Minor: Duplicate spaces now count towards the display message length. (Chatterino#3002) - Minor: Commands are now backed up. (Chatterino#3168) - Bugfix: Restored ability to send duplicate `/me` messages. (Chatterino#3166) - Bugfix: Notifications for moderators about other moderators deleting messages can now be disabled. (Chatterino#3121)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist:
CHANGELOG.mdwas updated, if applicableDescription
Whenever a message starts with
/or.we need to ignore first space as it is not treated as the message content by Twitch. Be it either a command starting with these characters or an escaped message, like. .foo bar.Look at the examples below (for better visibility, spaces were replaced with underscores)
"Goes through" is based on whether sending 2 identical messages in a row through Chatterino works or not.
(as interpreted by Twitch)
foofoofoo_barfoo_bar.foo_barbar.foo__barbar.foo_bar_bazbar_baz.foo_bar__bazbar__baz._foofoo._.foo.foo._foo_barfoo_bar._foo__barfoo__bar.__foo_barfoo_bar.__foo__barfoo__barFixes #3141