Strip leading @ and trailing , from username in /popout command #3217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Felanbird
force-pushed
the
minor/strip-from-popout-command
branch
from
99b4476
to
c4ddaf8
Compare
pajlada
approved these changes
Sep 4, 2021
zneix
added a commit
to SevenTV/chatterino7
that referenced
this pull request
Sep 12, 2021
Now we're on commit 9b9fd7d; Changes we've pulled from upstream: - Minor: Add `{channel.name}`, `{channel.id}`, `{stream.game}`, `{stream.title}`, `{my.id}`, `{my.name}` placeholders for commands (Chatterino#3155) - Minor: Fixed `/streamlink` command not stripping leading @'s or #'s (Chatterino#3215) - Minor: Strip leading @ and trailing , from username in `/popout` command. (Chatterino#3217) - Minor: Added `flags.reward_message` filter variable (Chatterino#3231) - Bugfix: Fixed a bug with usernames or emotes completing from the wrong position. (Chatterino#3229)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist:
CHANGELOG.mdwas updated, if applicableDescription
It dawned on me this command would be likely used with @ autocomplete.
This also strips
#but we never included that in the original Changelog so.