New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix "Change channel" popup title #3273
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While this change does fix the specific issue, it also changes the wording for normal split generation from: Select a channel to join
to Open channel name
I think the original should stay in some way, since it does its job explaining the windows functionality, with help from Join a twitch channel by its name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionality works as intended. 👍
The original phrasing was "Open channel name", and hte proposed change in this PR was "Select a channel to join" If you change the channel of a split, the title is "Change channel", so "Open channel" seems an appropriate mirror
Now we're on commit 4a90f10; Changes from upstream we've pulled: - Minor: Added new search predicate to filter for messages matching a regex (Chatterino#3282) - Minor: Subcategories in settings are now searchable. (Chatterino#3157) - Minor: Highlight usernames in /mods and /vips messages (Chatterino#3187) - Minor: Added chatter count to viewer list popout (Chatterino#3261) - Minor: Added `flags.first_message` filter variable (Chatterino#3292) - Minor: Removed duplicate setting for toggling `Channel Point Redeemed Message` highlights (Chatterino#3296) - Bugfix: Fixed a bug that caused zero-width emotes to be misaligned when the "Remove spaces between emotes" setting is on. (Chatterino#3249) - Bugfix: Fixed the "Change channel" popup showing a wrong window title (Chatterino#3273) - Bugfix: Fixed built-in Chatterino commands not working in whispers and mentions special channels (Chatterino#3288) - Bugfix: Fixed `QCharRef with an index pointing outside the valid range of a QString` warning that was emitted on every Tab press. (Chatterino#3234) - Bugfix: Fixed being unable to disable `First Message` highlights (Chatterino#3293) - Bugfix: Fixed `First Message` custom sound not persisting through restart. (Chatterino#3303)
Pull request checklist:
CHANGELOG.md
was updated, if applicableDescription
A simple fix; The
dialogTitle
parameter when callingshowChangeChannelPopup
was unused.Fixes #3269