Fixed Chatterino attempting to send empty messages in IRC #3355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mm2PL
force-pushed
the
fix/dont_send_empty_messages
branch
from
f8e18af
to
7f9f11c
Compare
Felanbird
approved these changes
Nov 19, 2021
pajlada
approved these changes
Nov 20, 2021
pajlada
changed the title
zneix
added a commit
to SevenTV/chatterino7
that referenced
this pull request
Nov 21, 2021
Now we're on commit b94e21a; Changes from upstream we've pulled - Minor: Added middle click split to open in browser (Chatterino#3356) - Minor: Made join and part message have links to usercards. (Chatterino#3358) - Minor: Show picked outcome in prediction badges. (Chatterino#3357) - Minor: Add support for Emoji in IRC (Chatterino#3354) - Bugfix: Fixed Chatterino attempting to send empty messages (Chatterino#3355)
D3XX3R
added a commit
to D3XX3R/chatterino7
that referenced
this pull request
Dec 25, 2021
commit 091f534 Merge: 0412658 51ece94 Author: zneix <zneix@zneix.eu> Date: Sun Dec 19 21:06:31 2021 +0100 Merge remote-tracking branch 'origin/master' into chatterino7 Now we're on commit 51ece94; Changes from upstream we've pulled - Bugfix: Fixed crash that would occur if the user tries to modify the currently connected IRC connection. (Chatterino#3398) commit 51ece94 Author: pajlada <rasmus.karlsson@pajlada.com> Date: Sun Dec 19 15:57:56 2021 +0100 Update Settings and Signals version (Chatterino#3398) Co-authored-by: zneix <zneix@zneix.eu> commit 60ff82f Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Sun Dec 19 14:39:01 2021 +0100 Bump actions/upload-artifact from 2.3.0 to 2.3.1 (Chatterino#3405) Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 2.3.0 to 2.3.1. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v2.3.0...v2.3.1) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit a33ff10 Author: Paweł <zneix@zneix.eu> Date: Fri Dec 17 08:18:10 2021 +0100 Updated OpenSSL 1.1 link in building docs (Chatterino#3407) commit d21bdc6 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Sun Dec 12 12:39:13 2021 +0100 Bump actions/download-artifact from 2.0.10 to 2.1.0 (Chatterino#3396) Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 2.0.10 to 2.1.0. - [Release notes](https://github.com/actions/download-artifact/releases) - [Commits](actions/download-artifact@v2.0.10...v2.1.0) --- updated-dependencies: - dependency-name: actions/download-artifact dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit c0a7455 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Sun Dec 12 12:39:04 2021 +0100 Bump actions/upload-artifact from 2.2.4 to 2.3.0 (Chatterino#3395) Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 2.2.4 to 2.3.0. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v2.2.4...v2.3.0) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit ac2bb40 Author: Felanbird <41973452+Felanbird@users.noreply.github.com> Date: Sun Dec 12 06:35:00 2021 -0500 Move '/live' logs to its own subDirectory (Chatterino#3394) Co-authored-by: pajlada <rasmus.karlsson@pajlada.com> commit fd77938 Author: LosFarmosCTL <80157503+LosFarmosCTL@users.noreply.github.com> Date: Sat Dec 11 12:56:19 2021 +0100 Fix special chars in Windows usernames breaking the storage of commands.json (Chatterino#3397) commit 0412658 Merge: a4ae09f 83f4d07 Author: zneix <zneix@zneix.eu> Date: Fri Dec 10 21:57:35 2021 +0100 Merge remote-tracking branch 'origin/master' into chatterino7 Now we're on commit 83f4d07; Changes from upstream we've pulled +- Bugfix: Fixed IRC colors not being applied correctly to NOTICE messages. (Chatterino#3383) +- Bugfix: Fixed IRC /kick command crashing if parameters were malformed. (Chatterino#3382) +- Bugfix: Fixed a crash that could occur on certain Linux systems when toggling the Always on Top flag. (Chatterino#3385) +- Bugfix: Fixed zero-width emotes sometimes wrapping lines incorrectly. (Chatterino#3389) commit 83f4d07 Author: Adam Davies <8650006+acdvs@users.noreply.github.com> Date: Mon Dec 6 21:01:16 2021 -0600 Add acdvs to contributor list (Chatterino#3391) commit 937e33a Author: Adam Davies <8650006+acdvs@users.noreply.github.com> Date: Mon Dec 6 16:49:08 2021 -0600 Fix zero-width emotes sometimes wrapping lines incorrectly (Chatterino#3389) Co-authored-by: Felanbird <41973452+Felanbird@users.noreply.github.com> Co-authored-by: pajlada <rasmus.karlsson@pajlada.com> commit b41df18 Author: pajlada <rasmus.karlsson@pajlada.com> Date: Sun Dec 5 13:38:21 2021 +0100 Fixed a crash that could occur on certain Linux systems when toggling the Always on Top flag. (Chatterino#3385) * Get `isVisible` value *before* toggling AlwaysOnTop hint * Add changelog entry commit 2c695a9 Author: pajlada <rasmus.karlsson@pajlada.com> Date: Sat Dec 4 17:05:57 2021 +0100 Fix IRC colors not being applied correctly to NOTICE messages (Chatterino#3383) * Normalize NOTICE message parsing for IRC Fixes Chatterino#1782 * Add changelog entry Co-authored-by: Felanbird <41973452+Felanbird@users.noreply.github.com> commit 568f652 Author: pajlada <rasmus.karlsson@pajlada.com> Date: Sat Dec 4 16:37:53 2021 +0100 Fix crash on missing parameters with IRC /kick command (Chatterino#3382) commit a4ae09f Merge: d8bc1af 3fcb634 Author: zneix <zneix@zneix.eu> Date: Sun Nov 28 18:39:21 2021 +0100 Merge remote-tracking branch 'origin/master' into chatterino7 Now we're on commit 3fcb634; Changes from upstream we've pulled - Bugfix: Fix Split Input hotkeys not being available when input is hidden (Chatterino#3362) - Bugfix: Fixed IRC highlights not triggering sounds or alerts properly. (Chatterino#3368) commit 3fcb634 Author: Rasmus Karlsson <rasmus.karlsson@pajlada.com> Date: Sun Nov 28 12:39:32 2021 +0100 MessagePredicate: Add virtual destructor commit 2075e88 Author: Rasmus Karlsson <rasmus.karlsson@pajlada.com> Date: Sun Nov 28 12:38:52 2021 +0100 Tokenizer.cpp: Rename local variable in regex matching commit 1795276 Author: mmb L <mammothb+git@gmail.com> Date: Sat Nov 27 21:51:37 2021 +0800 Rename local variable and remove unused local variable in IrcMessageBuild.cpp commit ec966a1 Author: mmb L <mammothb+git@gmail.com> Date: Sat Nov 27 21:27:01 2021 +0800 Remove local variables that are not referenced commit 7d350ad Author: mmb L <mammothb+git@gmail.com> Date: Sat Nov 27 21:06:41 2021 +0800 Refactor DownloaderManager private member variable names commit 7131f9e Author: mmb L <mammothb+git@gmail.com> Date: Sat Nov 27 21:52:18 2021 +0800 Rename updateOnlineChatters() argument name and local variable commit 8116c30 Author: Felanbird <41973452+Felanbird@users.noreply.github.com> Date: Sun Nov 28 06:19:08 2021 -0500 Add some commented First Message code for consistency (Chatterino#3370) commit 0deedf0 Author: Mm2PL <miau@mail.kotmisia.pl> Date: Sat Nov 27 15:03:10 2021 +0000 Add issue forms (Chatterino#3366) commit bc847f1 Author: pajlada <rasmus.karlsson@pajlada.com> Date: Sat Nov 27 15:35:13 2021 +0100 Fix IRC server messages not triggering sounds properly (Chatterino#3368) commit cb0c427 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Sat Nov 27 13:29:34 2021 +0000 Bump actions/cache from 2.1.6 to 2.1.7 (Chatterino#3364) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit f0df2fc Author: Mm2PL <miau@mail.kotmisia.pl> Date: Sat Nov 27 12:47:31 2021 +0000 Fix Split Input hotkeys not being available when input is hidden (Chatterino#3362) commit d8bc1af Merge: cfb274a 703f371 Author: zneix <zneix@zneix.eu> Date: Sun Nov 21 19:40:26 2021 +0100 Merge remote-tracking branch 'origin/master' into chatterino7 Now we're on commit 703f371; Changes from upstream we've pulled - Major: Added customizable shortcuts. (Chatterino#2340) commit cfb274a Merge: d2fe211 b94e21a Author: zneix <zneix@zneix.eu> Date: Sun Nov 21 19:13:10 2021 +0100 Merge commit 'b94e21a600537c444fe184a3f93302763d7db335' into chatterino7 Now we're on commit b94e21a; Changes from upstream we've pulled - Minor: Added middle click split to open in browser (Chatterino#3356) - Minor: Made join and part message have links to usercards. (Chatterino#3358) - Minor: Show picked outcome in prediction badges. (Chatterino#3357) - Minor: Add support for Emoji in IRC (Chatterino#3354) - Bugfix: Fixed Chatterino attempting to send empty messages (Chatterino#3355) commit 703f371 Author: Mm2PL <miau@mail.kotmisia.pl> Date: Sun Nov 21 17:46:21 2021 +0000 Add custom hotkeys. (Chatterino#2340) Co-authored-by: LosFarmosCTL <80157503+LosFarmosCTL@users.noreply.github.com> Co-authored-by: Paweł <zneix@zneix.eu> Co-authored-by: Felanbird <41973452+Felanbird@users.noreply.github.com> Co-authored-by: Rasmus Karlsson <rasmus.karlsson@pajlada.com> commit b94e21a Author: Mm2PL <miau@mail.kotmisia.pl> Date: Sat Nov 20 13:53:05 2021 +0000 Make join and part messages have user links (Chatterino#3358) Co-authored-by: pajlada <rasmus.karlsson@pajlada.com> commit 3a5c2b1 Author: Auro <35087590+MrAuro@users.noreply.github.com> Date: Sat Nov 20 08:27:26 2021 -0500 Middle click split header to open in browser (Chatterino#3356) Co-authored-by: pajlada <rasmus.karlsson@pajlada.com> commit b1e891b Author: Mm2PL <miau@mail.kotmisia.pl> Date: Sat Nov 20 12:21:42 2021 +0000 Fixed Chatterino attempting to send empty messages in IRC (Chatterino#3355) Co-authored-by: pajlada <rasmus.karlsson@pajlada.com> commit 56f2207 Author: Mm2PL <miau@mail.kotmisia.pl> Date: Sat Nov 20 11:52:27 2021 +0000 Show picked outcome in prediction badges. (Chatterino#3357) Co-authored-by: pajlada <rasmus.karlsson@pajlada.com> commit f58f352 Author: Felanbird <41973452+Felanbird@users.noreply.github.com> Date: Sat Nov 20 06:22:30 2021 -0500 Fix comment typo (Chatterino#3359) commit 6ac15ad Author: Mm2PL <miau@mail.kotmisia.pl> Date: Sat Nov 20 11:18:40 2021 +0000 Add support for Emoji in IRC. (Chatterino#3354) commit c19fd0d Author: Felanbird <41973452+Felanbird@users.noreply.github.com> Date: Sun Nov 14 07:21:17 2021 -0500 Add more ignored channels for context menu twitch links (Chatterino#3352) Co-authored-by: Rasmus Karlsson <rasmus.karlsson@pajlada.com> commit d2fe211 Merge: 8786c24 a689808 Author: zneix <zneix@zneix.eu> Date: Sun Nov 14 12:36:07 2021 +0100 Merge remote-tracking branch 'origin/master' into chatterino7 Now we're on commit a689808; Changes from upstream we've pulled: - Minor: Add clear cache button to cache settings section (Chatterino#3277) - Minor: Added support for opening channels from twitch.tv/popout links. (Chatterino#3309) - Minor: IRC now parses/displays links like Twitch chat. (Chatterino#3334) - Minor: Added button & label for copying login name of user instead of display name in the user info popout. (Chatterino#3335) - Minor: Make `/delete` errors a bit more verbose (Chatterino#3350) - Bugfix: Fixed the reconnection backoff accidentally resetting when thrown out of certain IRC servers. (Chatterino#3328) - Bugfix: Fixed underlying text from disabled emotes not being colorized properly. (Chatterino#3333) - Bugfix: Fixed IRC ACTION messages (/me) not being colorized properly. (Chatterino#3341) - Bugfix: Fixed splits losing filters when closing and reopening them (Chatterino#3351) - Bugfix: Fixed the first usercard being broken in `/mods` and `/vips` (Chatterino#3349) - Dev: Added CMake build option `BUILD_WITH_QTKEYCHAIN` to build with or without Qt5Keychain support (On by default). (Chatterino#3318) commit a689808 Author: Mm2PL <mm2pl+gh@kotmisia.pl> Date: Sat Nov 13 12:34:04 2021 +0000 Make `/delete` errors a bit more verbose (Chatterino#3350) Co-authored-by: Rasmus Karlsson <rasmus.karlsson@pajlada.com> commit 1ca3dfd Author: Mm2PL <mm2pl+gh@kotmisia.pl> Date: Sat Nov 13 12:07:29 2021 +0000 Fixed splits losing filters when closing and reopening them (Chatterino#3351) Co-authored-by: pajlada <rasmus.karlsson@pajlada.com> commit 6b3a420 Author: Mm2PL <mm2pl+gh@kotmisia.pl> Date: Sat Nov 13 11:11:18 2021 +0000 Fixed the first link being broken in `/mods` and `/vips` (Chatterino#3349) Co-authored-by: Felanbird <41973452+Felanbird@users.noreply.github.com> Co-authored-by: pajlada <rasmus.karlsson@pajlada.com> commit 85f6795 Author: pajlada <rasmus.karlsson@pajlada.com> Date: Fri Nov 12 17:26:38 2021 +0100 Refactor parts of SignalVectorModel (Chatterino#3342) commit bc0b7e4 Author: pajlada <rasmus.karlsson@pajlada.com> Date: Sun Nov 7 20:58:22 2021 +0100 Fix IRC actions not being colored properly (Chatterino#3341) commit 3c4331b Author: pajlada <rasmus.karlsson@pajlada.com> Date: Sun Nov 7 14:55:43 2021 +0100 Fix link parsing in IRC (Chatterino#3334) commit 7f4b739 Author: Mm2PL <miau@mail.kotmisia.pl> Date: Sat Nov 6 13:43:03 2021 +0000 Added support for opening channels from twitch.tv/popout links. (Chatterino#3309) Co-authored-by: pajlada <rasmus.karlsson@pajlada.com> commit a40677f Author: 1xelerate <59930937+1xelerate@users.noreply.github.com> Date: Sat Nov 6 08:44:27 2021 -0400 feat: Add copy button for both login & display name inside the user info popout (Chatterino#3335) Co-authored-by: Rasmus Karlsson <rasmus.karlsson@pajlada.com> commit 67eff75 Author: James Upjohn <jammehcow@jammehcow.co.nz> Date: Sun Nov 7 01:00:27 2021 +1300 feat: add "clear cache" button to settings (Chatterino#3277) Co-authored-by: Leon Richardt <leon.richardt@gmail.com> Co-authored-by: pajlada <rasmus.karlsson@pajlada.com> commit 9098e93 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Sat Nov 6 12:26:39 2021 +0100 Bump actions/checkout from 2.3.5 to 2.4.0 (Chatterino#3337) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit fc43870 Author: Mm2PL <miau@mail.kotmisia.pl> Date: Sun Oct 31 19:45:23 2021 +0000 Allow for building without QtKeychain (Chatterino#3318) Co-authored-by: Rasmus Karlsson <rasmus.karlsson@pajlada.com> commit 4b903d7 Author: pajlada <rasmus.karlsson@pajlada.com> Date: Sun Oct 31 15:44:38 2021 +0100 Fix the reconnection backoff accidentally resetting when thrown out of certain IRC servers (Chatterino#3328) commit d7337ff Author: Felanbird <41973452+Felanbird@users.noreply.github.com> Date: Sun Oct 31 07:16:07 2021 -0400 Add "drops" as an ignoredUsername for context menu twitch links (Chatterino#3310) commit 8b921ae Author: Ryan <59930937+1xelerate@users.noreply.github.com> Date: Sun Oct 31 07:15:49 2021 -0400 Add 1xelerate to the contributors list (Chatterino#3331) * added underscore prefix to file names since they started with a number commit 0b914cc Author: ALazyMeme <12804673+ALazyMeme@users.noreply.github.com> Date: Sun Oct 31 21:08:21 2021 +1000 Update contributors guide (Chatterino#3332) commit b4be7a4 Author: Ryan <59930937+1xelerate@users.noreply.github.com> Date: Sun Oct 31 06:37:06 2021 -0400 Fix underlying text from disabled emotes not being colorized after using /me (Chatterino#3333)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist:
CHANGELOG.mdwas updated, if applicableDescription
Fixes #1670.