Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorted usernames in "Users joined/parted:" messages #3421

Merged
merged 4 commits into from Dec 25, 2021

Conversation

zneix
Copy link
Collaborator

@zneix zneix commented Dec 24, 2021

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Description

Sorted usernames in these messages alphabetically. While I was at it, I noticed that messageText and searchText properties were missing, so I've also added them here. will be done separetly in another PR. Sorted out some code and added an early-out.

Fixes #3420

@zneix zneix requested a review from pajlada December 24, 2021 21:54
Copy link
Collaborator

@Felanbird Felanbird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality works as intended. 👍

@pajlada pajlada merged commit 45e4fc0 into master Dec 25, 2021
@pajlada pajlada deleted the zneix/feature/sort-users-joined-parted branch December 25, 2021 14:04
zneix added a commit to SevenTV/chatterino7 that referenced this pull request Dec 25, 2021
Now we're on commit efcef61; Changes from upstream we've pulled

- Minor: Sorted usernames in `Users joined/parted` messages alphabetically. (Chatterino#3421)
- Minor: Mod list, VIP list, and Users joined/parted messages are now searchable. (Chatterino#3426)
- Bugfix: Fixed IRC mentions not showing up in the /mentions split. (Chatterino#3400)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants