Add settings tooltips #3437
Add settings tooltips #3437
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| { | ||
| auto check = new QCheckBox(text); | ||
| this->addToolTip(*check, toolTipText); |
There was a problem hiding this comment.
warning: parameter 'toolTipText' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param]
src/widgets/settingspages/GeneralPageView.cpp:12:
+ #include <utility>| this->addToolTip(*check, toolTipText); | |
| this->addToolTip(*check, std::move(toolTipText)); |
| @@ -362,4 +393,23 @@ | |||
| } | |||
| } | |||
|
|
|||
| void GeneralPageView::addToolTip(QWidget &widget, QString text) const | |||
There was a problem hiding this comment.
warning: method 'addToolTip' can be made static [readability-convert-member-functions-to-static]
| void GeneralPageView::addToolTip(QWidget &widget, QString text) const | |
| void GeneralPageView::addToolTip(QWidget &widget, QString text) |
src/widgets/settingspages/GeneralPageView.hpp:205:
- void addToolTip(QWidget &widget, QString text) const;
+ static void addToolTip(QWidget &widget, QString text) ;| bool inverse = false); | ||
| ComboBox *addDropdown(const QString &text, const QStringList &items); | ||
| bool inverse = false, QString toolTipText = {}); | ||
| ComboBox *addDropdown(const QString &text, const QStringList &items, |
There was a problem hiding this comment.
warning: function 'chatterino::GeneralPageView::addDropdown' has a definition with different parameter names [readability-inconsistent-declaration-parameter-name]
ComboBox *addDropdown(const QString &text, const QStringList &items,
^src/widgets/settingspages/GeneralPageView.cpp:135: the definition seen here
ComboBox *GeneralPageView::addDropdown(const QString &text,
^src/widgets/settingspages/GeneralPageView.hpp:102: differing parameters are named here: ('items'), in definition: ('list')
ComboBox *addDropdown(const QString &text, const QStringList &items,
^
Pull request checklist:
CHANGELOG.mdwas updated, if applicableDescription
Resolves #2146
Displays a tooltip when hovering over a setting. This adds another parameter to each
GeneralPageView::add[Widget]function for easy definition withinGeneralPage. Uses the built-in Qt tooltip with a modified stylesheet to match the settings page colors.Initially, this PR adds tooltips for the settings listed in #2146 at the time of writing this.
Not sure about the tooltips for badge visibility. Should those stay on the labels?