Notebook::select now takes the optional parameter "focusPage". #3446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This parameter is true by default, and when set to false ensures that the page that was just selected will not be focused.
zneix
approved these changes
Jan 2, 2022
zneix
added a commit
to SevenTV/chatterino7
that referenced
this pull request
Jan 2, 2022
Now we're on commit 14d11b6; Changes from upstream we've pulled - Minor: Add search to emote popup. (Chatterino#3404) - Minor: Messages can now be highlighted by subscriber or founder badges. (Chatterino#3445) - Bugfix: Fixed crash that could occur if the user opens/closes ChannelViews (e.g. EmotePopup, or Splits) then modifies the showLastMessageIndicator setting. (Chatterino#3444) - Dev: Batch checking live status for channels with live notifications that aren't connected. (Chatterino#3442) - Dev: Added /fakemsg command for debugging (Chatterino#3448) - Dev: Notebook::select\* functions now take an optional `focusPage` parameter (true by default) which keeps the default behaviour of selecting the page after it has been selected. If set to false, the page is _not_ focused after being selected. (Chatterino#3446)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This parameter is true by default, and when set to false ensures that
the page that was just selected will not be focused.
Pull request checklist:
CHANGELOG.mdwas updated, if applicableDescription