fix: re-add build date to "About" page #3464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leon-richardt
force-pushed
the
fix/build-date
branch
from
a422849
to
6137e5e
Compare
Felanbird
reviewed
Jan 6, 2022
pajlada
approved these changes
Jan 6, 2022
The date of build has previously been provided via a define supplied by the CI runner. During the migration to GitHub Actions, this seems to have been missed. This fix relies on CMake generating and providing the timestamp itself, and passing it to the binary. Note that the timestamp will be of the date when the **build files** were generated, i.e., not when the project was compiled! For CI runs, however, the date of build file generation should be consistent with the date of compilation so this approximation is "good enough" for our purpose.
leon-richardt
force-pushed
the
fix/build-date
branch
from
cf3fdbf
to
9243e1a
Compare
Co-authored-by: Felanbird <41973452+Felanbird@users.noreply.github.com>
zneix
approved these changes
Jan 7, 2022
zneix
added a commit
to SevenTV/chatterino7
that referenced
this pull request
Jan 10, 2022
Now we're on commit dfa3818; Changes from upstream we've pulled - Bugfix: Re-add date of build to the "About" page on nightly versions. (Chatterino#3464)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist:
CHANGELOG.mdwas updated, if applicableDescription
Fixes #3430.
Relevant commit message:
Note that this only works for CMake-based builds so the QMake builds are out of luck. I won't bother figuring out how to supply the information platform-independently (Windows, macOS, Linux) with QMake. If someone wants to do so, please go ahead.
Commit 3e02e26 (also part of this PR) removes some comments which I felt were redundant, feel free to drop/revert the commit if you think otherwise.