Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: empty game update not updating header #3609

Merged
merged 3 commits into from Mar 19, 2022

Conversation

jupjohn
Copy link
Contributor

@jupjohn jupjohn commented Mar 16, 2022

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Description

This PR aims to fix #3224 where changing the game of a live channel to nothing would not update the split's title. This was caused by the Helix API call failing with an empty game ID and therefore not updating the game name.

@pajlada pajlada changed the title Fix/3224 empty game update title Fix empty game update not updating header Mar 19, 2022
@pajlada pajlada enabled auto-merge (squash) March 19, 2022 18:40
@pajlada pajlada merged commit 96e2d1f into Chatterino:master Mar 19, 2022
@jupjohn jupjohn changed the title Fix empty game update not updating header fix: empty game update not updating header Mar 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chatterino defaults to the last known game on existing splits if there is no game set
2 participants