feat: use message's original channel name when usercard popout is opened

[jupjohn]

Pull request checklist:

• CHANGELOG.md was updated, if applicable

Description

This PR aims to fix an issue where opening a user's popout from the usercard in a non-user channel (/mentions) doesnt open use the channel's name. This caused the popout to have an invalid path and 404.

I'm not saying my fix is 'correct', but it's the best I can do without either passing too much info down or reworking it for the sake of a popout.

Fixes #2248

[jupjohn]

oh yeah, fixes #2248

[Felanbird]

Functionality works as intended, fixing the original issue. 👍

[kornes]

requests to ivr api are also currently broken on /mentions tab due to same underlying issue. Can be fixed in scope of this PR here:

chatterino2/src/widgets/dialogs/UserInfoPopup.cpp

Line 858 in 146816a

this->userName_, this->channel_->getName(),

[jupjohn]

requests to ivr api are also currently broken on /mentions tab due to same underlying issue. Can be fixed in scope of this PR here:

Good catch, thanks! Will fix it later today.

[kornes]

and one more with same problem - middle mouse button on username

chatterino2/src/widgets/helper/ChannelView.cpp

Line 1719 in 495f4b1

openTwitchUsercard(this->channel_->getName(),

[jupjohn]

I'm wondering if it's worth rejigging this to pass through the original ChannelPtr instead of just a name. That way the snapshot of a user's messages can also be resolved for the original channel, mod actions work etc.

@Mm2PL thoughts?

[Felanbird]

While in debug mode the application crashes when the target channel is closed and you attempt to open the usercard in /mentions.

Normal mode does not crash you just receive a nice chatterino.ivr: Failed IVR API Call! 404 "" 🙂

[Felanbird]

I was holding-off on reviewing this PR as I wasn't sure if I wanted the /mentions tab context to be replaced (for searching through multiple days of mentions from the same user), but I think it's fine for the active channel context to be used instead.

[jupjohn]

There should've been a nullptr check when trying to get the channel from a weak pointer - I wouldn't expect it to crash. Will look into it later today

[jupjohn]

@Felanbird should be resolved. If the channel wasn't found I was passing an empty channel but not checking that on the other side. Have tested and works.

[Felanbird]

Crash is fixed - and the variation I was secretly hoping for exists.
When the tab is closed it seems to fallback to the pre-PR behavior which is great.