Add the ability to lock NotebookTab layout

[Infinitay]

Pull request checklist:

• CHANGELOG.md was updated, if applicable

Description

Gives users the ability to lock their tabs on Chatterino to prevent accidental movement.

chrome_kk9JcKz9g9.mp4

Additional Comments

I'm not sure if it would be better practice to rely only on the ChatterinoSetting rather than also using a private variable lockNotebookLayout_. Would appreciate some guidance.

[Infinitay]

I considered adding the menu action to NotebookTabs themselves, but midway I realized maybe it wouldn't be an ideal implementation. Originally, I considered giving each NotebookTab its own respective menu action. However, that would mean storing them all and updating them when the layout is (un)locked.

Another way I suppose would be to instead to re-use the menu action created it Notebook and add it to the NotebookTabs.

Would be a QoL to add the option to the NotebookTabs allowing users to (un)lock the layout with ease rather than clicking the on the blank space in the header. Additionally, it would follow inline with the existing ShowTabs (Toggle Visibility of Tabs) menu action being added to the blank space in the header and every NotebookTab. On the other hand, not doing so would reduce the menu action clutter if we just keep it only in Notebook/the blank space in addition to not much more work of course.

[Felanbird]

Would be a QoL to add the option to the NotebookTabs allowing users to (un)lock the layout with ease rather than clicking the on the blank space in the header. Additionally, it would follow inline with the existing ShowTabs (Toggle Visibility of Tabs) menu action being added to the blank space in the header and every NotebookTab. On the other hand, would reduce the menu action clutter if we just keep it only in Notebook/the blank space.

This is the important discussion, as visibility of this feature is the worry against it - the more visible it is the more likely somebody will accidentally click it.
From my experience with toggle visibility of tabs, users who have accidentally pressed it do not think to click in the empty spot where their channels used to be. My immediate assumption would be that this pattern would continue, especially if your tabs are still there, thinking to click the small empty area would be overlooked.

[kornes]

useful feature and agree with Felanbird that its risky because toggling it by mistake will frustrate unaware users. There needs to be some kind of feedback for user, showing why tabs cant be reorganized (would also add lock for tab closing).
My suggestion is to remove it from menus and add small custom button with 🔓 icon next to current ➕ for new tabs. Icon could change to open/closed state on click and blink when user tries to do forbidden actions (move, close tab) while locked.

[Infinitay]

Personally I'm conflicted on adding a button as a tab button for a visual indication. It would be nice, and I suppose in most cases it is more than fine. However, it would be annoying to have a special case where only the additional button would cause a new line where currently it wouldn't.

Or I suppose the true behavior is that the new te tab would be moved down on the new line and the + and 🔒 buttons next to it to fit all three together.

Although again, this is my only complaint with it and thought I should bring it up despite it probably not being the case for the majority of Chatterino users. Personally I rename and reorganize my tabs to make sure theres not just one or two tabs on a new line to free some space for chat viewability.

[pajlada]

👍
Added a commit to fix it not saving in settings
Added the menu item to the notebook tabs - I think it's worth it (see felanbird's comment)
Did some minor refactoring

[Felanbird]

Also I'll accept that visibility of tabs casing change as a separate PR :)