Add missing parent pointer to few QMessageBox and QFontDialog #3679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LosFarmosCTL
approved these changes
Apr 16, 2022
There was a problem hiding this comment.
#3672 was never an issue on macOS, since it just uses the native macOS font picker that does behave correctly by default, this does not break anything either, lgtm
4 tasks
Felanbird
reviewed
Apr 16, 2022
Co-authored-by: Felanbird <41973452+Felanbird@users.noreply.github.com>
pajlada
approved these changes
Apr 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist:
CHANGELOG.mdwas updatedDescription
This PR gives parent ptr to poor orphaned children, preventing them from appearing behind main chatterino window when Always on top is used.
tested on windows only
closes #3672