Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add chatter count for each category in viewer list #3683

Merged
merged 10 commits into from Apr 24, 2022

Conversation

badoge
Copy link
Contributor

@badoge badoge commented Apr 17, 2022

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Description

Adds the number of chatters to each category label in the viewer list.
image

@badoge badoge changed the title added chatter count for each category Add chatter count for each category in viewer list Apr 17, 2022
@badoge badoge marked this pull request as ready for review April 17, 2022 07:59
@kornes
Copy link
Contributor

kornes commented Apr 18, 2022

feature feels nichey, as personally i dont see practical use of these numbers, other than viewers curiosity.
Suggest to make it disabled by default and add as local-only toggle to context menu of viewers list QListWidget.

@Mm2PL
Copy link
Collaborator

Mm2PL commented Apr 18, 2022

Even more settings. Why is it detrimental to have this always on?

@kornes
Copy link
Contributor

kornes commented Apr 18, 2022

good UX is based on showing user only data which he needs, we already show total number of chatter in window tittle. From my pov adding extra visual noise to UI which serves little purpose for 99% of users just doesn't fit new default behavior.

Adding more settings is another thing which noone likes, that's why i suggested to add it in local scope of viewers list only, where it would be found only when someone checked context menu. This would be middle ground with no negative effects for both sides and allow more customization which is always nice.

@LosFarmosCTL
Copy link
Contributor

LosFarmosCTL commented Apr 18, 2022

How is this behavior being always-on affecting anyone negatively? I fail to see how this is 'UI clutter', showing the number of entries in a list is a very standard behavior of any UI and its not like the viewer list is some dashboard with 100 graphs and control panels, I highly doubt 3-6 chars more at the end of a list header will annoy anyone, while providing value for people who need it.

Hiding this behind some context menu would just result in 90% of users not even knowing it existed.

@kornes
Copy link
Contributor

kornes commented Apr 18, 2022

to rephrase my point: if some data, no matter of its size in UI, gonna be useful for very small portion of users if any (and that's my main assumption here) i just wouldn't show it by default.

Did any of you guys ever found yourself asking "how many vips or mods are watching?" i never did. But maybe its just me-thing and i already spammed here too much, so lets others talk :D

@treuks
Copy link
Contributor

treuks commented Apr 18, 2022

Look, I'm just going to interject in real quick, this feature is great, I really like it.

There is no need to make it a setting, there is no need to be able to toggle this, THIS DOES NOT REMOVE ANYTHING, IT ONLY ADDS SOMETHING. It's neither a side-grade nor a down-grade.

It's not extra information you don't need, it fits in perfectly, like it has always been there. I have genuinely wondered for how much people are in the viewer list right now, and in what groups they are precisely.

If Chatterino was a minimalistic application, we would not have all the features we have right now. Don't come in here with this minimalistic approach.

Please, leave it as it is, in my opinion, there are no visual changes needed.

Copy link
Collaborator

@Felanbird Felanbird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good addition 👍

src/widgets/splits/Split.cpp Outdated Show resolved Hide resolved
Co-authored-by: Kasia <zneix@zneix.eu>
@pajlada pajlada enabled auto-merge (squash) April 24, 2022 15:11
@pajlada pajlada merged commit 7246ab3 into Chatterino:master Apr 24, 2022
pajlada added a commit that referenced this pull request May 28, 2022
This fixed a bug introduced in #3683

Co-authored-by: pajlada <rasmus.karlsson@pajlada.com>
@badoge badoge deleted the count branch July 4, 2022 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants