Prevent user from entering incorrect characters in Live Notifications channels list #3715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iProdigy
reviewed
May 7, 2022
Co-authored-by: Sidd <iProdigy@users.noreply.github.com>
QRegularExpression is implicitly shared, so no need to worry about ownership, copies are cheap https://doc.qt.io/qt-5/implicit-sharing.html#list-of-classes
zneix
reviewed
May 8, 2022
Add unit tests for the regular expressions to validate our assumptions
pajlada
approved these changes
May 8, 2022
pajlada
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist:
CHANGELOG.mdwas updated, if applicableDescription
Live notifications for channels which are not open in tabs are queried by user supplied names, in single call to Helix /streams.
Twitch will return error 400 Bad Request, when one of passed channel names will contain illegal characters.
That will cause chatterino to silently fail and not deliver any notifications, even for correct names on the list
This PR fixes that by adding input validation support for TableView in editor mode.
User won't be allowed to enter characters not matching pattern of correct twitch username: