Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix links with no thumbnail having previous link's thumbnail #3720

Merged
merged 4 commits into from May 22, 2022
Merged

Fix links with no thumbnail having previous link's thumbnail #3720

merged 4 commits into from May 22, 2022

Conversation

qooq69
Copy link
Contributor

@qooq69 qooq69 commented May 8, 2022 •
edited

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Description

Fixes #1971

Felanbird
Felanbird approved these changes May 15, 2022
View reviewed changes
Copy link
Collaborator

@Felanbird Felanbird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality works as intended. 👍
before:
image

after:
image

zneix
zneix approved these changes May 22, 2022
View reviewed changes
Copy link
Collaborator

@zneix zneix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works

pajlada
pajlada requested changes May 22, 2022
View reviewed changes
Copy link
Member

@pajlada pajlada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than this nitpick, looks good

src/providers/LinkResolver.cpp Outdated Show resolved Hide resolved
@pajlada pajlada enabled auto-merge (squash) May 22, 2022 10:50
@pajlada pajlada merged commit 1b3aa34 into Chatterino:master May 22, 2022
@Mm2PL Mm2PL mentioned this pull request Jun 6, 2022
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pajlada pajlada pajlada approved these changes

@Felanbird Felanbird Felanbird approved these changes

@zneix zneix zneix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Image not correctly updated when hovering over two adjacent links
4 participants
@qooq69 @pajlada @Felanbird @zneix