Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed total views from the usercard #3792

Merged
merged 5 commits into from
Jun 5, 2022

Conversation

mmattbtw
Copy link
Contributor

@mmattbtw mmattbtw commented Jun 2, 2022

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Description

Twitch removed the 'total views' counter from the channel page, dashboard, and I am certain the number isn't being updated anymore. Announcement of total views being deprecated

@neil-lobo
Copy link

https://discuss.dev.twitch.tv/t/get-users-api-endpoint-view-count-deprecation/37777

@iProdigy
Copy link
Contributor

iProdigy commented Jun 2, 2022

Also consider removing the field from the underlying data models

Copy link
Member

@pajlada pajlada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the now unused ui_.viewCountLabel member in UserInfoPopup
Also remove the viewCount member from the model

CHANGELOG.md Outdated Show resolved Hide resolved
@mmattbtw mmattbtw requested a review from pajlada June 4, 2022 19:45
CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Felanbird <41973452+Felanbird@users.noreply.github.com>
@Felanbird Felanbird enabled auto-merge (squash) June 5, 2022 20:31
@Felanbird Felanbird merged commit d29243a into Chatterino:master Jun 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants