Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix highlights not showing in mentions #3801

Merged
merged 6 commits into from
Jun 6, 2022
Merged

Fix highlights not showing in mentions #3801

merged 6 commits into from
Jun 6, 2022

Conversation

pajlada
Copy link
Member

@pajlada pajlada commented Jun 5, 2022

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Description

  • Add failing tests
  • Fix benchmarks not compiling
  • Fix showInMentions not forwarding properly
  • Include showInMentions for user highlights
  • Add ostream operator for HighlightResult
  • Add changelog entry

@pajlada pajlada requested review from zneix and Mm2PL June 5, 2022 22:08
zneix
zneix approved these changes Jun 6, 2022
View reviewed changes
Copy link
Collaborator

@zneix zneix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straightforward fix, thanks!

@Mm2PL Mm2PL mentioned this pull request Jun 6, 2022
Closed
4 tasks
Mm2PL
Mm2PL approved these changes Jun 6, 2022
View reviewed changes
Copy link
Collaborator

@Mm2PL Mm2PL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BroBalt fix works, tests pass as expected

@Mm2PL Mm2PL merged commit 9219647 into master Jun 6, 2022
@Mm2PL Mm2PL deleted the fix/highlight-show-in-mentions branch June 6, 2022 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mm2PL Mm2PL Mm2PL approved these changes

@zneix zneix zneix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pajlada @Mm2PL @zneix